Problem/Motivation

Testing in #3519605: SophronMimeTypeMapFactory should just override MimeTypeMapFactory::doCreateMap(), I think I found that the test DummyMimeTypeMapLoadedSubscriber is not getting executed. It seems like it's a service setup issue.

Proposed resolution

Fix.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3519804

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !11874

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review

mondrake changed the visibility of the branch 3519804-dummymimetypemaploadedsubscriber-does-not to hidden.

mondrake changed the visibility of the branch 3519804-dummymimetypemaploadedsubscriber-does-not to active.

mondrake’s picture

mondrake
Location 🇮🇹
commented

The test-only job does not seem to work - maybe because the change is only of the service yml file?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Needs work

I think we can use autoconfiguration here and I have confirmed that the test finds the problem. Nice spot.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review

Thanks for review

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Reviewed the code changes and agree with moving legacy tests. Unfortunately a test-only run doesn't not fail to confirm the bug is fixed as the code that would fail has been moved to a new test class. Not sure if it's worth it pursuing?

mondrake’s picture

mondrake
Location 🇮🇹
commented

I think #7 stands for test failure confirmation? Test-only does not fail because afaics the yaml service file change does not get reverted.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +Contributed project blocker
Related issues: +#3519605: SophronMimeTypeMapFactory should just override MimeTypeMapFactory::doCreateMap()

This is blocking #3519605: SophronMimeTypeMapFactory should just override MimeTypeMapFactory::doCreateMap().

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs review » Reviewed & tested by the community

Based on #10 I think we can RTBC this now.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 7da6cdb and pushed to 11.x. Thanks!

  • alexpott committed 7da6cdbf on 11.x 
    Issue #3519804 by mondrake, kim.pepper, alexpott:...

mondrake closed merge request !11874

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.