Problem/Motivation

During our tests, we found out that the Zoom Component view provided by this module would cause some UI bugs within our site and it wouldn't let the user see the meeting in a new browser tab.

We found that the Client view was available and would fullfil our needs.

Proposed resolution

While keeping the component view as default, we could offer an option in the Field Formatter to choose between component and client view.

Remaining tasks

MR to be submitted.

User interface changes

Add a new Field Formatter option.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#6 rebase-zoom-video.jpg29.47 KBtostinni

Issue fork zoom_video-3519365

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tostinni created an issue. See original summary.

tostinni opened merge request !10

tostinni’s picture

tostinni commented
Status: Active » Needs review

Here is the MR with our updated Field Formatter that will allow displaying of Client view as a new option (default to Component view).
The coding style for the JS is a little bit different, but I hope this wouldn't be a problem.

tostinni’s picture

tostinni commented
Related issues: +#3542826: Switch automatically Zoom UI to Drupal's language

Adding an automatic language detection to switch the Zoom UI to a supported language.
See #3542826: Switch automatically Zoom UI to Drupal's language

danmer’s picture

danmer commented
Status: Needs review » Needs work

@tostinni I can't merge this MR via UI; I'm not sure why. Can you check if this MR can be merged properly locally, or do you want me to do that and merge manually?

tostinni’s picture

tostinni commented
Status: Needs work » Needs review
StatusFileSize
new rebase-zoom-video.jpg29.47 KB

@danmer, I went to https://git.drupalcode.org/project/zoom_video/-/merge_requests/10 and clicked on "Rebase source branch" so now this MR is mergeable again after the updates that have been made to the project.

danmer’s picture

danmer commented
Version: 1.3.5 » 1.3.7
Status: Needs review » Reviewed & tested by the community

Thx, The MR is merged

danmer’s picture

danmer commented
Version: 1.3.7 » 1.3.8
Status: Reviewed & tested by the community » Fixed

Added to the new release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.