Problem/Motivation

Drupal core is at CKEditor5 v41.3.1.

Editor Advanced Link is currently at CKEditor5 v35.1.0

Steps to reproduce

As determined from web/core/yarn.lock, and this module's yarn.lock.

Proposed resolution

Upgrade dependencies, especially CKEditor5 to match Drupal core.

Issue fork ckeditor5_dev-3519136

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jcandan created an issue. See original summary.

idiaz.roncero made their first commit to this issue’s fork.

idiaz.roncero opened merge request !15

idiaz.roncero’s picture

idiaz.roncero
he/him
Primary language Spanish
Location Madrid
commented
Status: Active » Needs review
Related issues: +#3429152: Automated Drupal 11 compatibility fixes for ckeditor5_dev

Created MR adapting D11 package.json dependencies and webpack.config.js.

This issue should go hand in hand with "Automated Drupal 11 compatibility fixes for ckeditor5_dev", as both of them port ckeditor5_dev to D11 parity.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

But does this mean Drupal 10 compatibility is not provided at the same time though?

smustgrave’s picture

smustgrave commented

Just got added and triaging this queue and this one I'm not sure what would be best. I limited the 2.0.x to 10.5 and 11 only so maybe it wouldn't be too bad. May be we need to add comments like if
10.5 => use xyz
11.1 => use xyz

smustgrave closed merge request !15

  • smustgrave committed d0293ea0 on 2.0.x 
    feat: #3519136 Upgrade starter template CKEditor to match Drupal core at...
smustgrave’s picture

smustgrave commented
Version: 1.0.x-dev » 2.0.x-dev
Status: Needs review » Fixed

Actually nvm the versions being proposed is the version that's in 10.5, so while yes we are not fully inline with core we are definitely better then 15 majors back..

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.