Overview

#3501290: Introduce unit test coverage for both ComponentSource plugins (Block + SDC) added unit tests for sdc and block ComponentSource plugins.

Missing: the js ComponentSource plugin.

Proposed resolution

  • Change JsComponentTest to final class JsComponentTest extends ComponentSourceTestBase {.
  • Generalize JsComponentTest::testRenderComponent() into ComponentSourceTestBase, hence modifying ComponentSourceTestBase::testRenderComponentLive() to cover it all

User interface changes

None.

Comments

wim leers created an issue. See original summary.

wim leers’s picture

Title: [PP-1] Add `JsComponent` unit test » [PP-1] Update JsComponentTest to subclass ComponentSourceTestBase for consistent test coverage
Issue summary: View changes

Actually \Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\JsComponentTest already exists!

wim leers’s picture

Title: [PP-1] Update JsComponentTest to subclass ComponentSourceTestBase for consistent test coverage » [PP-2] Update JsComponentTest to subclass ComponentSourceTestBase for consistent test coverage
Status: Active » Postponed
Related issues: +#3518832: ComponentSource robustness: add `ComponentSourceTestBase::testGetClientSideInfo()`, +#3518838: ComponentSource robustness: add `ComponentSourceTestBase::testSettings()`
wim leers’s picture

Issue tags: +maintainability

wim leers’s picture

Status: Postponed » Closed (outdated)
wim leers’s picture