Overview
#3501290: Introduce unit test coverage for both ComponentSource plugins (Block + SDC) added unit tests for sdc and block ComponentSource plugins.
Missing: the js ComponentSource plugin.
Proposed resolution
- Change
JsComponentTesttofinal class JsComponentTest extends ComponentSourceTestBase {. - Generalize
JsComponentTest::testRenderComponent()intoComponentSourceTestBase, hence modifyingComponentSourceTestBase::testRenderComponentLive()to cover it all
User interface changes
None.
Comments
Comment #2
wim leersActually
\Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\JsComponentTestalready exists!Comment #3
wim leersWait for #3518832: ComponentSource robustness: add `ComponentSourceTestBase::testGetClientSideInfo()` and #3518838: ComponentSource robustness: add `ComponentSourceTestBase::testSettings()`, ideally, but not necessarily.
Comment #4
wim leersComment #6
wim leersThis was completed in #3518838: ComponentSource robustness: add `ComponentSourceTestBase::testSettings()` by @isholgueras!
Comment #7
wim leers