The replacement of service "redirect_response_subscriber" does not work

Could you create a merge-request please?

And it could be interesting to have a functional test to cover that problem.

Thanks @b-prod for opening this issue. Confirming the patch you provided worked for me.

@mably Opened the issue branch and am doing some further testing and development. I will open the MR soon hopefully!

Is it still a problem? Could we have a MR please?

MR created. Please review.

We also need a test for this.

Why is it done in the domain_source submodule and not in the main domain module?

I do not see any reference to some domain_source specific code in the DomainSourceRedirectResponseSubscriber class.

Does your use case require the activation of the domain_source module?

If not, this should definitely be moved to the domain module. Will work on it.

Had to add back some duplicated code from the RedirectResponseSubscriber class to properly handle the InvalidArgumentException that generates the status 400 message.

Would be great to have more detailed instructions to help reproduce the problem.

I recommend enabling our domain-aware RedirectResponseSubscriber by default to prevent potential issues with custom cross-domain redirects.

MR code has been updated accordingly.

@mably - I agree with the approach here to move this from domain_source into domain.
Patch applies cleanly to drupal/domain (dev-2.0.x c210cf8)

I am able to add a redirect to a local domain managed by domain module.

I think this is good to go

Added a functional test:

namespace Drupal\Tests\domain\Functional;

use Symfony\Component\HttpFoundation\Response;

/**
 * Tests the domain redirection handling.
 *
 * @group domain
 */
class DomainRedirectTest extends DomainTestBase {

  /**
   * {@inheritdoc}
   */
  protected static $modules = ['domain', 'domain_test_redirect'];

  /**
   * Test redirections.
   */
  public function testDomainRedirect() {
    $this->domainCreateTestDomains(2);

    $domains = $this->getDomains();
    $domain = $domains['one_example_com'];

    // Redirection targeting a registered domain url.
    $target_url = $domain->getPath() . 'target-path';
    $this->drupalGet('/non-trusted-redirect', [
      'query' => ['url' => $target_url],
    ]);

    // Check that the redirection has been properly allowed.
    $this->assertEquals($target_url, $this->getUrl());

    // Target an external url that is not a registered domain.
    $target_url = 'https://two.example.com';
    $this->drupalGet('/non-trusted-redirect', [
      'query' => ['url' => $target_url],
    ]);

    // Verify that the redirection was rejected as expected.
    $this->assertSession()->statusCodeEquals(Response::HTTP_BAD_REQUEST);
    $this->assertSession()->responseContains('Redirects to external URLs are not allowed');

  }

}

We should be ready to go.