Problem/Motivation

We are trying to deprecate node_add_body_field in #3489266: Deprecate node_add_body_field() but currently NodeTypeForm is calling this for the testing profile (since #3488742: Stop calling node_add_body_field() from NodeTypeForm) just for these Nightwatch tests.

In #3467492: [policy, no patch] Replace Nightwatch with Playwright I think we all agree that Nightwatch is unreliable, and looking at the tests they are doing an awful lot of costly operations via the UI that if it were a PHP test we could use API to do for us (install the site, install modules, set up content types, etc).

Instead of adding even more UI clunk to Nightwatch in order to setup a body field, let's just convert these to WebDriver tests. There's nothing in there that can't be done in PHP afaict.

Proposed resolution

Convert ckEditor5EditorHeightTest to a WebDriver test.

Remaining tasks

Do it

Issue fork drupal-3517024

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !11825

acbramley’s picture

acbramley commented
Status: Active » Needs review

Repeat job passed 100/100 times.

https://git.drupalcode.org/issue/drupal-3517024/-/jobs/4965455

mstrelan’s picture

mstrelan commented
Status: Needs review » Reviewed & tested by the community

This looks great and is so much simpler.

acbramley’s picture

acbramley commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a rebase now #3517023: Convert ckEditor5CodeSyntaxTest to WebDriver test is in

acbramley’s picture

acbramley commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll

Back to RTBC

  • catch committed 2867913e on 11.2.x 
    Issue #3517024 by acbramley: Convert ckEditor5EditorHeightTest to...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Fixed

That is so much more straightforward. Committed/pushed to 11.x and cherry-picked to 11.2.x, thanks!

  • catch committed 2ded5d0f on 11.x 
    Issue #3517024 by acbramley: Convert ckEditor5EditorHeightTest to...

catch closed merge request !11825

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.