Problem/Motivation

The Slim select library provides settings, but currently, only some of them can be overridden on the Drupal level.

Steps to reproduce

Proposed resolution

Extend slim-select.js to allow overridde all available settings.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 slim_select-3516978.patch4.05 KBpiotrsmykaj

Issue fork slim_select-3516978

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

piotrsmykaj created an issue. See original summary.

piotrsmykaj opened merge request !12

piotrsmykaj’s picture

piotrsmykaj commented
Assigned: piotrsmykaj » Unassigned
Status: Active » Needs review
StatusFileSize
new slim_select-3516978.patch4.05 KB
andras_szilagyi’s picture

andras_szilagyi commented

Looks good

aporie’s picture

aporie
Primary language French
commented

Looks good + this patch also fix an issue with placeholder from v2 which prevented slim select from using Drupal translation. It was using the default "Select Value" settings from slim_select library:

Change from:

placeholder = placeholderText

To 

placeholderText = placeholderText

andras_szilagyi’s picture

andras_szilagyi commented
Status: Needs review » Fixed

Thank you for your work, it is merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.