Since the form implemented by LogCacheTagsForm is a configuration form, its parent class should be ConfigFormBase, not FormBase. The first has methods a module can use to load configuration values and save them.

Issue fork log_cache_tags-3516341

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

avpaderno created an issue. See original summary.

ankit_k made their first commit to this issue’s fork.

ankit_k opened merge request !5

ankit_kumar’s picture

ankit_kumar
He/Him
commented
Status: Active » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

Since the parent class is changed, there are other changes to be done:

  • The constructor needs to be changed
  • The configuration object is retrieved with $this->config()
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno

I am working on this.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: avpaderno » Unassigned

  • avpaderno committed 888d20f4 on 2.0.x authored by ankit_k 
    Issue #3516341: The parent class of LogCacheTagsForm is wrong
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.