Problem/Motivation

Related bs_base issue #3474790: Remove theme-options.yml feature.

Issue fork bs_lib-3515918

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pivica created an issue. See original summary.

pivica’s picture

Status: Active » Needs review

MR is ready. There is one additional small change

-        if (preg_match_all('/\s\*\s(.*?)\n\s\*\/\nfunction\s' . $parent_theme . '_bs_update_(\d{4})/', $content, $matches)) {
+        if (preg_match_all('/\s\*\s(.*?)\n\s\*\/\nfunction\s' . $parent_theme . '_bs_update_(\d+)/', $content, $matches)) {

That will allow writting of update function with more the 4 numbers like

function bs_base_bs_update_200001($target_theme_name) {}

  • pivica committed b5a5c2b9 on 2.0.x
    Issue #3515918 by pivica: Remove theme-options.yml feature from theme...
pivica’s picture

Status: Needs review » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.