Problem/Motivation

Navigation module menu items for its settings and block layout are defined with different weights, hence they do not appear together in a clean core installation. That could be confusing for site administrators.
Navigation menu items

Proposed resolution

  • Define the same weight for both menu items. Leaving the value empty to use the default value might be the preferred approach
  • While we are here, rename Navigation Settings route controller and menu item to Navigation settings to be consistent with other settings pages in core
  • While we are here, add a simple description to Navigation settings menu item to be consistent with other core settings menu links. A simple string like Manage navigation settings. would be enough.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 updated-navigation-links.png12.53 KBivavictoria
organize-menu.png12.16 KBplopesc

Issue fork drupal-3515777

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

ivavictoria’s picture

ivavictoria
she/her
Primary language English
Location Wisconsin, USA
commented
Assigned: Unassigned » ivavictoria

I'm at DrupalCon Atlanta and am interested in giving it a try! Let's see how far I get. ;-)

ivavictoria opened merge request !11657

ivavictoria’s picture

ivavictoria
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Active » Needs review
StatusFileSize
new updated-navigation-links.png12.53 KB

Ok, It's updated, and when I test it, the navigation menu items are reordered and match in text case:
Updated menu with reordered links

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Issue summary: View changes
Status: Needs review » Needs work

Good progress so far! :)

Added a minor comment to the MR to reduce a bit the file footprint. Besides that, would be great if the Navigation settings form page could be updated as well. It is defined in navigation.routing.yml file.

Thank you!

ivavictoria’s picture

ivavictoria
she/her
Primary language English
Location Wisconsin, USA
commented

I've changed the case in that page's title to match the link in the menu. Is that the only thing that needed updating?

ivavictoria’s picture

ivavictoria
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Needs work » Needs review
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

It looks great!

Marking as RTBC. Thank you!

  • catch committed 1a2079a4 on 11.x 
    Issue #3515777 by ivavictoria, plopesc: Reorganize Navigation menu items...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

catch closed merge request !11657

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.