Overview

@wim leers and @mglaman have confirmed that there are no technical reasons to continue supporting Drupal 10.

Proposed resolution

Before XB 1.0, drop support for Drupal 10 and only support Drupal 11 and up.

User interface changes

None

Issue fork experience_builder-3515504

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Drop support for Drupal 10 » Drop support for Drupal 10 🚀
Issue tags: +Novice

philalonso made their first commit to this issue’s fork.

philalonso opened merge request !823

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs work
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +sprint
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: Unassigned » tedbow
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Title: Drop support for Drupal 10 🚀 » Drop support for Drupal 10, require 11.1.2🚀

Since our `experience_builder.info.yml` was already requiring "^10.4 || ^11.1" and we going through the trouble to remove logic specifically Drupal 10, let just require 11.1.2 because we have special logic for that version since it came 2 months and we are still in alpha stage

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#8++ — let's do that!

That will mean that we'll be able to drop 100% of our version_compare() calls!

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: tedbow » Unassigned
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » tedbow
Status: Needs review » Needs work

Looks lovely!

But not currently mergeable: a merge conflict needs to be resolved.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Reviewed & tested by the community

Re @wim leers approval I think this good since I merged 0.x. Last phpunit job is running. Will merge when/if it passes

  • tedbow committed e71ce970 on 0.x authored by philalonso 
    Issue #3515504 by tedbow, philalonso, wim leers, longwave: Drop support...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Reviewed & tested by the community » Fixed
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: tedbow » Unassigned
nagwani’s picture

nagwani commented
Issue tags: -sprint

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.