There is 2 issues we should address to fix Drupal 11 compatibility:

web/modules/contrib/commerce_product_taxonomy_filter/src/Plugin/views/filter/TaxonomyIndexTid.php	238	Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

web/modules/contrib/commerce_product_taxonomy_filter/config/optional/views.view.product_terms.yml	201	Support from all Views contextual filter settings for the default_argument_skip_url setting is removed from drupal:11.0.0. No replacement is provided. See https://www.drupal.org/node/3382316.

Issue fork commerce_product_taxonomy_filter-3515430

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dillix created an issue. See original summary.

dillix opened merge request !9

dillix’s picture

dillix commented
Assigned: dillix » Unassigned
Status: Active » Needs review
interdruper’s picture

interdruper commented
Status: Needs review » Needs work

A couple of problems with patch MR9:

  • src/Plugin/views/filter/TaxonomyIndexTid.php: accessCheck(TRUE) prevents the module to be installed using Drush (user anonymous)
  • /commerce_product_taxonomy_filter.module, line 94: "TypeError: Cannot access offset of type array on array in Drupal\Core\Database\Query\Merge->key() (line 331 of /drupal/picnegre/web/core/lib/Drupal/Core/Database/Query/Merge.php)": 'key' should be replaced by 'keys', see change record https://www.drupal.org/node/2205327

skounis made their first commit to this issue’s fork.

skounis opened merge request !10

andriic made their first commit to this issue’s fork.

andriic’s picture

andriic commented

Missed schema file was added to MR10

andriic’s picture

andriic commented
Status: Needs work » Needs review
dillix’s picture

dillix commented
Assigned: Unassigned » dillix
Status: Needs review » Needs work

We need to fix phpstan and phpcs errors. I already fixed some problems for D11 compatibility in MR10.

dillix’s picture

dillix commented
Assigned: dillix » Unassigned
Status: Needs work » Needs review

I've made all planned fixes and now pipeline for MR10 is green. Also I think we should make 2.0.x version since minimal required Drupal version was bumped to 10.3+.

dillix’s picture

dillix commented
Version: 1.0.x-dev » 2.0.x-dev

  • dillix committed 8b75720c on 2.0.x authored by skounis 
    feat: #3515430 Drupal 11 compatibility

By: dillix
By: interdruper
By:...
dillix’s picture

dillix commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dillix’s picture

dillix commented

I created new stable release 2.0.0 for Drupal 10.3+.

dillix closed merge request !9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.