Problem/Motivation

system/base provides a clearfix utility class.

This class is used in about 20 places in Drupal core, however they are all admin pages.

We should check each page to see whether the clearfix class/CSS rule is actually required, and remove it if it's not.

This may eventually allow us to move clearfix to its own library, or deprecate the class entirely.

Steps to reproduce

Proposed resolution

Remaining tasks

Check each page to see whether the clearfix class/CSS rule is actually required, and remove it if it's not.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3515097

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented

I am working on it.

utkarsh_kumar_singh opened merge request !11736

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Status: Active » Needs review

Fixed Audit use of the clearfix class.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

@utkarsh_kumar_singh I see you removed it but did you check any of the pages that it was being used? Don't see the audit part anywhere on the ticket and seems we jumped straight to removal. So moving to NW

quietone’s picture

quietone commented
Issue summary: View changes
Issue tags: +Needs manual testing
Related issues: +#3328118: Discuss removing 'clearfix' class from Claro, +#3164890: Remove floats and clearfixes

Adding related.

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented

I am looking into it.

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented

Hii @smustgrave, Thank you for the feedback.

Yes, I manually reviewed and tested all the pages where the clearfix class was being used. After thorough testing, I confirmed that the removal does not impact the layout or functionality on any of those pages. Based on this, I proceeded to remove the class from the admin theme as it was no longer needed.

Please let me know if there's any specific page or scenario you'd like me to double-check. I'm happy to revisit and make any necessary adjustments.

catch’s picture

catch
he/him
Primary language English
commented
Title: Audit use of the clearfix class » [PP-1] Audit use of the clearfix class
Status: Needs work » Postponed

I think this needs to be postponed on #3328118: Discuss removing 'clearfix' class from Claro which is already dealing with the Claro usages.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.