Problem/Motivation

CacheTagsSimplifySubscriber calls the \Drupal::config() method, this is not recommended in object oriented code.

Steps to reproduce

https://git.drupalcode.org/project/cache_tags_simplify/-/jobs/4763018

Proposed resolution

CacheTagsSimplifySubscriber should use dependency injection to inject the config factory service.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork cache_tags_simplify-3515049

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff’s picture

prudloff commented
Issue tags: +Novice

farzana.farook made their first commit to this issue’s fork.

farzana.farook opened merge request !2

farzana.farook’s picture

farzana.farook commented

Created merge request. Replaced \Drupal::config() with dependency injection using config.factory.

farzana.farook’s picture

farzana.farook commented
Status: Active » Needs review
prudloff’s picture

prudloff commented
Status: Needs review » Needs work

Thanks for the MR!

phpcs reports a problem though: https://git.drupalcode.org/issue/cache_tags_simplify-3515049/-/jobs/9385302

farzana.farook’s picture

farzana.farook commented
Status: Needs work » Needs review
prudloff’s picture

prudloff commented
Status: Needs review » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.