Problem/Motivation

Add unit tests to verify:
- An untranslatable node does not trigger the notification when enabled
- An node with no translations which is enabled does not trigger the warning
- A translated node which is disabled does not trigger the warning
- A translated node which is enabled does trigger the warning

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_translation_reminder-3514986

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bramdriesen created an issue. See original summary.

miroslavstankov made their first commit to this issue’s fork.

miroslavstankov opened merge request !8

miroslavstankov’s picture

miroslavstankov commented
Status: Active » Needs review

This test includes all main scenarios for ReminderService:
Untranslatable entity → no warning
No translations → no warning
Disabled bundle → no warning
Enabled bundle with custom message → warning shown
Enabled bundle with default message → warning shown

ankitv18’s picture

ankitv18 commented
Status: Needs review » Needs work

Test look fine but there should be a proper documentation for this test class and methods which is currently missing.

Pending: docBlock for class and methods.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Thank you so much @miroslavstankov

Happy to merge this once the PHPCS and PHPSTAN errors are fixed :-). Assigning credits.

In case you don't know, you can see the reports in the GitLab runner results, and some are visible on the merge request diff.

danrod’s picture

danrod
Location Ottawa
commented

I'll look into the PHPCS / PHPSTAN errors

danrod’s picture

danrod
Location Ottawa
commented
Assigned: Unassigned » danrod
danrod’s picture

danrod
Location Ottawa
commented
Status: Needs work » Needs review
danrod’s picture

danrod
Location Ottawa
commented

Fixed the PHPCS and PHPSTAN errors, kindly review.

danrod’s picture

danrod
Location Ottawa
commented
Assigned: danrod » Unassigned
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.