When you change the value of CKeditor5 form element, the form is not marked as 'edited'. You don't get a warning to leave the page.

Issue fork modified_form_alert-3514649

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sander wemagine created an issue. See original summary.

sander wemagine opened merge request !6

sander wemagine’s picture

sander wemagine commented

I have created a merge request that fixes the problem for CKeditor5.

Please note: I removed the previous CKeditor-checking code.
We might need to re-added it, but it was causing an error on my install, so I removed it. The previous code was for CKeditor 4 maybe?

I got this error with the previous code:
Uncaught ReferenceError: CKEDITOR is not defined

sander wemagine’s picture

sander wemagine commented
Status: Active » Needs review
anruether’s picture

anruether
Primary language German
Location Bonn
commented

@sander wemagine Can you add steps to reproduce? I don't experience this on drupal 11.2.4

anruether’s picture

anruether
Primary language German
Location Bonn
commented

And: Did you try the patch in #3466302: Use formUpdated event instead of change event?

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Postponed (maintainer needs more info)

This issues seems to be fixed by issue #3466302: Use formUpdated event instead of change event.
Can you confirm @sander wemagine?

  • jeroent committed 8e05fe11 on 2.1.x authored by kksandr 
    [#3514649] feat: CKeditor5 changes are not detected

By: sander wemagine...

  • jeroent committed 30057c31 on 2.1.x 
    Revert "[#3514649] feat: CKeditor5 changes are not detected"

This...

  • jeroent committed d1ae63f8 on 2.1.x 
    Revert "Revert "[#3514649] feat: CKeditor5 changes are not detected""...

jeroent closed merge request !6

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.