When no mailing lists are active the message that is shown to the user is

'Any mailing list is avaiable'

Instead of this if you show

'There are no active mailing lists available.'

It would be more explicit than the above message
I did not create a patch as this was trivial. The message is in line 154 of user_mailman_register.module

File version
// $Id: user_mailman_register.module,v 1.30 2008/03/11 22:09:21 samuelet Exp $

CommentFileSizeAuthor
#1 user_mailman_register-cleanup.patch23.52 KBeMPee584

Comments

eMPee584’s picture

eMPee584 commented
Title: Dubious comment when no active mailing lists are present » Module grokability
Version: 6.x-1.1 » 6.x-1.x-dev
Component: User interface » Code
Assigned: Unassigned » eMPee584
Priority: Minor » Critical
Status: Active » Needs review
StatusFileSize
new user_mailman_register-cleanup.patch23.52 KB

This was not the only confusing thing. It was a real pain to try and understand the code, especially because of the obscure variable names and so on. Here's a patch that cleans things up a bit.

samuelet’s picture

samuelet commented
Status: Needs review » Fixed

Committed.
Thanks to all.

anoopjohn’s picture

anoopjohn commented
Status: Fixed » Active

The issue I reported is still present in the code :-)

eMPee584’s picture

eMPee584 commented
Status: Active » Postponed (maintainer needs more info)

Prove!

samuelet’s picture

samuelet commented

anoopjohn , i suppose you did not correctly update the module or you downloaded it before the archive was updated.
As you can see here (line 219):
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/user_mailma...
It's fixed in the 6.x code.
If code is ok, but message is still there, it could be a cache (try to empty drupal cache) or a translation issue (check the string in the translation interface).

eMPee584’s picture

eMPee584 commented

Also, the current dev tarball contains a stupid bug (sorry! 2 missing braces..), please wait some more hours until it gets re-regenerated..

anoopjohn’s picture

anoopjohn commented
Status: Postponed (maintainer needs more info) » Fixed

I disproved myself :-). I checked the latest tarball and it is present. Was my mistake because I probably downloaded it right after the post about the commit before the nightly build. Am marking this issue as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.