Overview

In the “Review changes” panel, Code Components and Overrides are shown with the generic component icon. This inconsistency makes it harder to interpret the changes in the review changes panel.

Proposed resolution

Use the correct icons in the review changes panel.

User interface changes

CommentFileSizeAuthor
#8 Updated Publish Modal.png1.22 MBreneelund
Screenshot 2025-03-15 at 12.04.43 PM.png450.87 KBlauriii

Issue fork experience_builder-3513145

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

penyaskito made their first commit to this issue’s fork.

penyaskito opened merge request !788

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review

Gave this a quick try. Not sure how to create overrides though.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

@penyaskito You need to enable xb_dev_js_blocks module for overrides to show up in the UI.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Thanks! I validated the fix works for overrides too.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Status: Needs review » Needs work

Looks great!

Two minor things:

  1. I think we can get rid of all instances of IconType.COMPONENT1, as well as the styling for that type. Unless, see my question below.
  2. Can you please also update the stories for the PublishReview component? We don't have a lot of stories in our Storybook, this component does have them. 🙂

Question to @lauriii, is it okay to use the same code icon for the exposed code components? They get a different icon the sidebar in that case, that's why I'm asking.

Also, do we want to update the icon for Global CSS as well while we're here? The API endpoint returns icon: 'cms' for it, so we may want to adjust this on the backend, but it's also easy to look at the entity type in the frontend component.

reneelund’s picture

reneelund commented
StatusFileSize
new Updated Publish Modal.png1.22 MB

I just added a screenshot of what this modal should look like.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue tags: +Atlanta2025
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review

NR.
#7: Got rid of every Component1Icon. There are a couple of cases that could be discussed:
1. New component menu: Does nothing, Laurii confirmed we can delete that.
2. Not sure about my PageInfo checks, definitely appreciate feedback there @balintbrews

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Test failure is unrelated.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Status: Needs review » Needs work
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review

Fixed feedback.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Assigned: Unassigned » balintbrews

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Assigned: balintbrews » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.