Problem/Motivation

We have a bug that shows up in the editor (Oops...
It seems that the editor encountered an error. Save your content and refresh the page. If the error persists, contact your site administrator.)

It occurs when we accept or refuse a modification (add or deletion) on the comment.

Here is what we get on the console log :

ckeditor5-dll.js?v=44.0.0:5 Uncaught CKEditorError: a[r(...)](...) is not a function
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#erro...(...)](...) is not a function
at d (track-changes.js:5:240894)
at h (track-changes.js:5:240721)
at vc._refreshSuggestionsChain (track-changes.js:5:240362)
at Wr._onAttributesChange (track-changes.js:5:236214)
at Wr.setAttribute (track-changes.js:5:32511)
at Wr.s (js_gRYYJysKquOIQ-sb1PpK2CMUT3Ok7wVToAGWLK-Z9ZQ.js?scope=footer&delta=20&language=fr&theme=rapportcongres&include=eJydVMtu4zAM_CErOvUDFovm2L3sXaBt2mEjSwJF5_H3pZxXnbpG0YNhajgckSKlmnqXKKGtr0ZVxyhZGNKLfZjmPRsPglmqpg2u2WNLEtm-nlLMEOQ_Q8hd5AGEYvjTQhLkOXWrYm9RcNEJLNR4fBuHGplCf_HGIEz1WCSdZpEii0tHsCXoCatuUi-WgsoH8JuWx6S_u2eDQ9pBpvwj8k4G_xp6Cvgj-qDGpyxc8qPGugTN3l7ILsUjMrauPi_zXEehdaAfY_LQoC2AUcBcgW_iRAubumNv1rfEkziZ9couYA5uPVpUOUZutTljEFtMM5lmIYZxoHFwHYKMrNkhc2QTolBHzbRTXqWfSndNOfOeJ_oKWxPyHup4IdrZ6rcSw4BB1lJ8imA8UC777Sgr__y7fbUXzd40Owg9rm7ejd7nhhE11zvrAa6FlsLK8durMc80Mj4UNwmy4Jbj8K_TtuGzW6XjAbfT7Dz7csKGwP_dgdakw5G_EOTsvygK1Dfwes00mA5oPIX9DJ8OLuU5We-hj_0G3uE0w0ulcjZlymd4lnJ1ZtABy3sE3mgquerIa-4332VVdfqc6STrmN4tcy-hKo-Hq0fyrQZ-XnwAWywj7g:82:3510)
at Wr.fire (ckeditor5-dll.js?v=44.0.0:5:725118)
at [as accept] (ckeditor5-dll.js?v=44.0.0:5:728799)
at Object.callback (track-changes.js:5:223758)
at ji._runPendingChanges (ckeditor5-dll.js?v=44.0.0:5:473839)

Steps to reproduce

Use the functionnality track changes, add or delete something and then try to accept it (after saving it one time).

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 Screenshot 2025-12-24 100453.png55.19 KBfrancismak
#5 Screenshot 2025-12-24 100334.png31.42 KBfrancismak
#5 Screenshot 2025-12-24 100251.png29.19 KBfrancismak
#2 2025-04-04_12:06:31.png41.5 KBsalmonek

Issue fork ckeditor5_premium_features-3512257

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eme created an issue. See original summary.

salmonek’s picture

salmonek commented
StatusFileSize
new 2025-04-04_12:06:31.png41.5 KB

Hi @eme I'm not sure if I understood reproduction steps correctly. What I did was:

  1. Create a node
  2. Add some text without track changes
  3. Commented something
  4. Added suggestion in the comment scope
  5. Saved node
  6. Accept/refuse suggestion

Screen:
screensot
In that scenario both approve and reject worked ok.

Additionally could you please share a console log errow with JS aggregation disabled? This would help to identify one of files in trace.
Also is that happening in Realtime collaboration or Non-realtime mode?

mdusza’s picture

mdusza commented
Status: Active » Postponed (maintainer needs more info)
mdusza’s picture

mdusza commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

Closing the issue for now as we need more information - we're happy to re-open it once you are be able to provide more details.

francismak’s picture

francismak commented
Version: 1.4.0 » 1.6.4
Status: Closed (cannot reproduce) » Active
StatusFileSize
new Screenshot 2025-12-24 100251.png29.19 KB
new Screenshot 2025-12-24 100334.png31.42 KB
new Screenshot 2025-12-24 100453.png55.19 KB

Hi,

Sorry for re-opening this ticket. We got the exact same error message.

Here are some details:
Drupal version: 10.5.6
ckeditor5_premium_features: 1.6.4
collaboration: non-real time

Steps:
1. Create a new node
2. Add one line in body, save
3. Edit the node, enable tracking changes
4. Delete a few letters from first line, add a second line, save
5. Edit the node, tracking accept/reject, get the error

Did several tests:
1. As long as you delete letters from first line, it will break.
2. If you add letters in first line ONLY, it won't break.
3. If you have two lines saved already, enable tracking, leave the first line untouched, and you start delete letter from second line, it won't break.

Please see attached screenshots for JS error.

mdusza’s picture

mdusza commented

Hi francismak,

Thanks for providing reproduction steps - we'll look into this issue.

salmonek’s picture

salmonek commented

Hi francismak,

Thank you, I confirm that those steps allows to reproduce the error. The coincidence is that we have encountered this error when we were internally testing an upcoming CKEditor 5 Plugin Pack feature.
I'll post the patch soon.

salmonek opened merge request !42

salmonek’s picture

salmonek commented
Status: Active » Needs review

Patch uploaded

francismak’s picture

francismak commented

Thank you @salmonek for the quick fixes. I used the patch from MR and tested, no more errors and all 'accept'/'discard' functions are working as expected.

salmonek’s picture

salmonek commented
Status: Needs review » Reviewed & tested by the community

  • salmonek committed 71c5b73a on 1.6.x 
    Resolve #3512257 "Track changes accept refuse error"
salmonek’s picture

salmonek commented
Status: Reviewed & tested by the community » Fixed

Released in 1.7.0

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.