Problem/Motivation

Wrapper div is not removed when scrolling is enabled and saved

The problem happens because of the disconnect between the table model element and div. When the wrapper div is added for scrollable table, it is not part of the table model. When we load the the content edit screen second time, the wrapper div in not upcast to be part of the table element

Steps to reproduce

  1. Create a new content, with scrolling enabled and save
  2. Edit the content and disable scrolling.
  3. The wrapper div is not removed and scrolling is still enabled

Proposed resolution

.
Here are the steps to fix it.

  1. Remove the code for adding wrapper div.
  2. Implement a wysiwig filter to add the wrapper div in the content view. The wrapper div is never saved in the db. It is only visible in the front end.

Remaining tasks

Create a patch for the fix

User interface changes

No changes

API changes

No changes

Data model changes

No changes

Issue fork uswds_ckeditor_integration-3511674

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ramarajuk created an issue. See original summary.

ramarajuk’s picture

ramarajuk commented
Issue summary: View changes

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !95

smustgrave’s picture

smustgrave commented
Version: 3.1.3 » 3.1.x-dev
Status: Active » Needs review

Gawd I hate ckeditor..but try this solution.

  • smustgrave committed 8c609a66 on 3.1.x 
    Issue #3511674 by ramarajuk: Scrollable table: wrapper div not removed...
smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.