Problem/Motivation

We have added better cache tag assertions over time, like CacheTagGroupedLookups.

These two don't actually give us useful performance information any more relative to the others, so I think we can just remove them from tests.

'CacheTagChecksumCount' => 38,
'CacheTagIsValidCount' => 43,

We can also deprecate the getter methods for these.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3511123

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

> not really a way to deprecate an array key.

Well, the array keys map to methods, so deprecating those should trigger deprecations.

Possibly this is major/critical as it looks like StandardPerformanceTest has a new fairly frequent random fail?

andypost’s picture

andypost
he/him
Primary language Russian
commented

yesterday faced the same working on #3502973: Remove UI and routes for the ability to update modules and themes via update.module and authorize.php
ref https://git.drupalcode.org/issue/drupal-3502973/-/jobs/4561201
basically it vary

    Standard Performance (Drupal\Tests\standard\FunctionalJavascript\StandardPerformance)
     ✘ Standard performance
       ┐
       ├ Failed asserting that two arrays are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊      ],
       ┊      'CacheSetCount' => 45,
       ┊      'CacheDeleteCount' => 0,
       ┊ -····'CacheTagChecksumCount'·=>·38,
       ┊ -····'CacheTagIsValidCount'·=>·43,
       ┊ +····'CacheTagChecksumCount'·=>·37,
       ┊ +····'CacheTagIsValidCount'·=>·42,
       ┊      'CacheTagInvalidationCount' => 0,
       ┊      'CacheTagLookupQueryCount' => 21,
       ┊      'CacheTagGroupedLookups' => Array &2 [
       │
       │ /builds/issue/drupal-3502973/core/tests/Drupal/Tests/PerformanceTestTrait.php:679
       │ /builds/issue/drupal-3502973/core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:175
       │ /builds/issue/drupal-3502973/core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:57

catch opened merge request !11386

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Critical

Bumping to critical due to the random test failures, I think all the places we're removing the deprecated methods are using the new better ones now.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs work

phpstan needs fixes

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Green pipeline now.

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Checked deprecation messages.

Read through the change record as well.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 08d8a27 and pushed to 11.x. Thanks!

  • alexpott committed 08d8a27a on 11.x 
    Issue #3511123 by catch, berdir: Remove cache tag checksum assertions...

quietone closed merge request !11386

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.