Overview

Global region in the "Review changes" panel is overly verbose because it includes the theme name.

Proposed resolution

It would be fine for this to just say the name of the region, since it's only possible to modify and review regions for the default theme.

User interface changes

CommentFileSizeAuthor
Screenshot 2025-03-01 at 9.22.45 AM.png79.53 KBlauriii
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lauriii created an issue. See original summary.

johnwebdev made their first commit to this issue’s fork.

johnwebdev’s picture

Status: Active » Needs review

This MR just implements the most trivial fix, and that is changing the label in PageRegion. But, this also affects the label everywhere, and that might not be desirable? In that case, maybe we should add a dedicated getAutoSaveLabel() method on entities instead?

wim leers’s picture

Component: Page builder » Config management
Assigned: Unassigned » wim leers
Category: Bug report » Task
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Usability
Related issues: +#3501600: Split 1 PageTemplate config entity into N PageRegion config entities

This definitely is not a bug. It works exactly as intended.

#4: that's exactly why I named it this way, actually! 😄 Plus, it matched the label of the page template prior to #3501600: Split 1 PageTemplate config entity into N PageRegion config entities — which also included the theme name.

But @lauriii beat me to it:

since it's only possible to modify and review regions for the default theme.

Agreed. There's no potential for confusion.

I'll fix the last failing test and get this in.

wim leers’s picture

Assigned: wim leers » Unassigned

  • wim leers committed 4f40333c on 0.x authored by johnwebdev
    Issue #3510440 by johnwebdev, wim leers, lauriii: Global region in the "...
wim leers’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.