Need a global header that looks nice and shows up instead of:
#3510425: Hide SDDS header blocks within XB
This is the header that was designed in Figma but really anything that "looks okay" is fine:
Create a global block and update the theme config to add it to the header.
User will see the header block in XB
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | sdds-header-logo-menus.png | 50.25 KB | kristen pol |
| #7 | drupalorg-home-page-main-nav.png | 662.93 KB | kristen pol |
| #6 | civictheme-website-header-area.png | 904.23 KB | kristen pol |
| #5 | sdds-block-header-regions.png | 71.54 KB | kristen pol |
| xb-updated-design-header.png | 959.69 KB | kristen pol |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
kristen polBumping to major as this is likely to be part of the official xb-demo and we want it to look good.
Comment #3
kristen polFigma is noted here:
#3468620: [META] Create updated custom components for Starshot Demo Design System
Comment #4
kristen polI'm going to split this into 2 issues... I'm going to get the config into this one so it's ready for styling by Alan for tomorrow.
Comment #5
kristen polThese are the header region placements
Comment #6
kristen polWith that info ^ and comparing to civictheme.io, we should use header middle 2 for the logo and main nav and header middle 3 for the right info.
It doesn't need to look exactly like the Figma design.
Comment #7
kristen polWe should do it closer to what's on Drupal.org since it's not quite the same as the designs.
But we don't need to do the mega menu.
Comment #8
kristen polHere's what it's looking like... now I need to get it into the config
Comment #10
kristen polI may just merge this but I'll see if anyone is around to review.
How to test:
ddev drush recipe themes/contrib/demo_design_system/starshot_demo/recipes/starshot_demo_recipe_menus/If this works, the dev guide will need updating. As more recipes are added, we should be able to have one recipe that is dependent on the others though may have a hiccup with #3511805: Fix or workaround XB image alt bug that prevents saving SDDS components so may need to split that out.
Comment #11
kristen polDoing footer here:
#3511866: Create SDDS global footer config
Comment #12
kristen polI'm going to merge and keep going but still would be nice for others to try it in case there are some issues I didn't find
Comment #14
kristen polremoving... duplicate comment
Comment #15
kristen polThis and #3511866: Create SDDS global footer config can be tested at the same time by using the latest dev code.
Styling will happen here #3511877: Add SDDS global header styling
Comment #17
kristen polFrom penyaskito via slack: missed the composer.json dependency to default_content... the starshot_demo theme depends on it on info.yml, but it's not in composer.json
Comment #19
kristen polThanks!
Comment #20
kristen polComment #21
gábor hojtsySimilar to #3511866-14: Create SDDS global footer config, I think there was a misunderstanding here? I think we would thruthfully demonstrate the current features of XB if there would be a general header region, rather than it being subdivided and a column (or header column) component placed to set the layout up there with menu blocks placed and the learn more button component placed within it.
Comment #22
gábor hojtsyWhen a region is configured in XB, that is saved in page region config entities, NOT as block placement entities see https://git.drupalcode.org/project/experience_builder/-/blob/0.x/docs/co...
Comment #23
kristen polCopying from footer issue:
Yeah, when I created these, I wasn't aware of XB's global placement workflow.
Block placement has been removed and regions simplified per:
#3512657: Remove block placement of SDDS header+footer blocks
#3512060: Too many global regions in SDDS
but the content is still there.
Tweaks can be in the header/footer styling issues.