Overview

This test seems to be failing pretty often on CI. Running locally seems to work pretty consistently.

Proposed resolution

I've noticed that, different to almost all of our other tests, this test uninstalls and reinstalls between each it block. Perhaps this is related?

I also observed a JS error "cannot read property 'style' of null" (or undefined, I can't remember) which I have tracked down to the useSyncIframeHeightToContent hook - the line if (element.style.height.endsWith('vh')) { in the following:

    const elements: NodeListOf<HTMLElement> = iframeHTML.querySelectorAll('*');
    elements.forEach((element: HTMLElement) => {
      if (element.style.height.endsWith('vh')) {
        const vhValue = parseFloat(element.style.height);
        const newHeight = (vhValue / 100) * height;
        element.style.maxHeight = newHeight + 'px';
        resizeIframe();
      }
    });

User interface changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jessebaker created an issue. See original summary.

jessebaker’s picture

Assigned: jessebaker » Unassigned
Status: Active » Needs review
wim leers’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +e2e

This has passed 4 times in a row now. Quietly confident.

No need to wait only longer then. Let's get it in.

wim leers’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.