Problem/Motivation

Currently the project depends on config_split 1.x, with a "develop" split configured.
The Belgian (and other) websites are using config split in order to split of language-specific configuration (e.g. enable FR language for the .be website, which should not happen in the general project).

I propose to update the config_split module to its version 2.x as soon as possible, because that introduces the concept of patching. Rather than splitting a whole config YML file, config_split only puts the changes in the split directory.

Steps to reproduce

The default language.negotiation.yml looks like this:

session:
  parameter: language
url:
  source: path_prefix
  prefixes:
    en: en
    '': null
  domains:
    en: ''
selected_langcode: site_default

When using config_split 1.x, we split the whole file. If later the "session" or "selected_langcode" property would change in the default config, it will not propagate to the split off configurations.

Proposed resolution

Use config_split 2.x, so the above configuration would be stored in config/drupal_be split folder as follows:

adding:
  url:
    prefixes:
      nl: nl
      fr: fr
      de: de
    domains:
      nl: ''
      fr: ''
      de: ''
removing:
  url:
    prefixes:
      '': null

This alters only the prefixes content, nothing else.

If we decide to let all spin-off sites use config_split, it will be a lot more maintainable this way.

Remaining tasks

- Create MR to update to config_split 2.x + update existing splits

Issue fork la_eu-3509585

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

svendecabooter created an issue. See original summary.

svendecabooter’s picture

Status: Active » Needs review
svendecabooter’s picture

svendecabooter’s picture

Priority: Normal » Major
esmoves’s picture

Will be discussed on April 30th meeting

svendecabooter’s picture

Rebased MR on the latest 1.0.x code.
Not sure how to fix the failed pipeline though...

kraut’s picture

Status: Needs review » Fixed

Merged it now as the fake pipeline came from the issue fork.

kraut’s picture

Status: Fixed » Needs work

Wait we still need to update/rebase now at least la_de ...

svendecabooter’s picture

Thanks for the merge.
I guess we can now create followup tickets, so different local sites can request to merge in their own config_split.config_split.la_[LOCAL_SITE].yml and appropriate config/la_[LOCAL_SITE] config split folder.

taran2l’s picture

Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.