Closed (fixed)
Project:
Experience Builder
Version:
0.x-dev
Component:
Theme builder
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Feb 2025 at 20:55 UTC
Updated:
14 Apr 2025 at 10:34 UTC
Jump to comment: Most recent
Comments
Comment #2
wim leersAFAICT this is a duplicate of #3508937: Global AssetLibrary should render with its auto-saved state (if any) when rendered in the XB UI. @balintbrews will be able to confirm.
Comment #3
balintbrewsIt's related, but not the duplicate of that issue. Here is our current treatment of global CSS.
AssetLibraryentity. In this early implementation only the source code is saved, and we only use the config entity as the mean of storage — no generated library from it gets attached to the page.JavaScriptComponententity whenever any of those changes occur. As part of compiling the CSS for the component, we take what is in global CSS, and use it for building the CSS with Tailwind CSS. Global CSS serves as the Tailwind configuration, but any additional styles will also make it to the compiled output. We concatenate the component's CSS source (after it's transpiled with Lightning CSS) with this compiled output, and save it to the code component's compiled CSS property.I won't go into details here how this will need to be rectified and improved. (Please mind that we needed to get to
0.2.0-alpha1. 🙂)As far as the context for this issue, the solution is easy. We need to trigger a component auto-save also when the global CSS is updated. I'll have an MR shortly.
Comment #5
balintbrewsComment #6
effulgentsia commentedIs the intent of this to make sure that the component you're currently editing is re-autosaved when global css is changed? But other components don't automatically get recompiled with the new global css, right? I think that's fine if that's what we want the scope of this issue to be, but just want to make sure that's explicit if that's the case.
Comment #7
lauriiiInteresting. Doesn't this mean there could be some pretty interesting behavior if different components included a different version of the global CSS? If that's the case, we should probably try to solve this in a way where we didn't have to include the global CSS with individual components.
Comment #8
balintbrewsYes, it's a bit rough around the edges at the moment. That's what I meant when I said that the approach will need to be rectified. ☺️
I have some thoughts on how, I will articulate that in a new issue, if that sounds good to you. In the meantime, I would suggest that we land this improvement on what we currently have.
Comment #9
wim leersWho should review this? @hooroomoo? @jessebaker?
Most importantly, what's left after this? AFAICT it is:
Assigning to @balintbrews for answering both of those questions.
Comment #10
nagwani commentedComment #12
balintbrews