The AdminToolbar (Navigation)items are not clickable when we're on the navigation layout page.
1). Install latest version of drupal11.
2). Install Navigation module from extend
3). go to Configuration > UserInterface > Navigation Layout and try to click on any Navigation links.
layout-builder-block[tabindex="-1"] {
/* Remove pointer-events: none; */
pointer-events: auto; /* Make it clickable */
}
Provide an "Edit Mode" for this page, so visitors will be able to use the navigation while it is disabled.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
quietone commentedComment #3
rinku jacob 13 commentedComment #4
rinku jacob 13 commentedComment #6
rinku jacob 13 commentedThe above MR will fix the navigation link click issue. However, for the second-level menu, if there is a submenu, the page immediately refreshes. I need to work on fixing that issue. For the navigation link fix, I’m awaiting feedback from the maintainers to confirm if I’m on the right track. Once I receive approval, I will focus on addressing the second issue I discovered. Adding screen records for the reference.
Comment #7
rinku jacob 13 commentedEven though I have made the menus clickable, they are not directing to the corresponding pages. Need to work on fixing this as well.
Comment #8
rinku jacob 13 commentedComment #11
plopescAdded new approach to try to address this issue.
When the user lands in the Navigation blocks page, there is a button to enable the edition mode. Only when the edition mode is enabled, LB taker over the navigation.
Once changes are saved or discarded, the user is back to normal mode, where the left bar navigation is fully functional.
Comment #12
plopescComment #13
m4oliveiLooks great! Really like this approach. Just some super nit picks for naming. Otherwise looking good. I would favor this approach over messing with the styles.
Comment #14
plopescThank you for your review @m4olivei. Applied your suggestions.
Back to Needs Review.
Comment #15
sagarmohite0031 commentedHello,
Tested and verified on Drupal 11.
MR applied successfully.
But issue is still there, When I'm clicking on on any option its redirect me to Edit layout for Navigation layout Add to Default shortcuts
Steps to reproduce
1). Install latest version of Drupal 11.
2). Install Navigation module from extend
3). go to Configuration > User Interface > Navigation Layout and try to click on any Navigation links.
Please check Attachment-
Comment #16
m4oliveiLooks great! Nice improvement. Thanks @plopesc!
Comment #17
ckrina+1 to the RTBC on a UX perspective while testing this locally, after being asked by @catch to +1 the UX changes.
It would be great though that UI changes that have considerable UX changes are reviewed by a UX person before RTBC it. And to make UX people life easier it would be great that any RTBC comes with a proper issue summary update and screenshots or videos to help other UX reviewers without git knowledge to see and understand the changes.
That said, 2 things:
1. Great work everyone with this change! It takes away on of the worst UX behaviors from this page.
2. We really need to start a plan to remove Layout Builder from this UI. It wasn't designed for this and it's an overkill that results in a very poor UX.
Comment #18
catchCommitted/pushed to 11.x, thanks!