Drupal 11 compatible

@deepali sardana Is the info.yml the only deprecation?

@andileco What's the status of your work? 😊 can this be reviewed?

To be honest, I lost track. I think this should definitely be reviewed, though. Thanks for working on this module!

Is the update of this module to Drupal 11 available?

It still needs to be tested and checked if all deprecations are fixed

Hello all,

After applying the MR as a patch, the upgrade status module says everything's fine and notifications work, but, phpstan, phpcs & eslint are saying something about low success rates:

https://git.drupalcode.org/issue/notificationswidget-3508957/-/pipelines...

I'm changing the issue status now.

Best,
Orkut

I fixed all of ESLint errors.

Hi Tom, can you check that what you committed is correct? The diff looks way too large to be just eslint fixes.

Sorry for my late reply.
I checked my commit and this commit is correct because many of diffs are prettier/prettier errors which are fixed using ESLint with the `--fix` option.

Pipeline log on the previous commit 9a8e23f2:
https://git.drupalcode.org/issue/notificationswidget-3508957/-/jobs/4848...

If no need to fix prettier/prettier errors in this issue, I'll revert prettier/prettier problems.

Could this issue be focussed on getting a D11 release out, while the linting issues get moved to another issue?
The current 2.0.0-alpha7 release also has these code style issues, so it's not a deterioration...
Then people could upgrade to D11, and hopefully the code styling issues could then be fixed soon afterwards...
Or is there a case to be made to take that all together?

Happy to merge if this is tested. Ok for me to fix stylelint etc in another issue.

I tested this module in our installation, looks OK to me.
Found a small bug/typo and fixed it (Warning: Undefined variable $addtionalEntityTypes in Drupal\notifications_widget\Form\NotificationsWidgetSettingsForm->submitForm() (line 360 of modules/contrib/notificationswidget/src/Form/NotificationsWidgetSettingsForm.php).)

If the merge conflict is fixed, this can be merged.

I fixed merge conflict, please review.

Tested again, works fine for me. MR looks OK.

I spotted one more thing in the JS code.