Problem/Motivation

PHP 8.4 has been released, and this module is triggering a "use explicit nullable type" deprecation.

This is part of Drupal's coding standards now, but since the issues to fix phpcs in this module have stalled, I'm opening up this issue to fix this single deprecation to avoid the warnings on PHP 8.4.

After updating to PHP 8.4:

FILE: /src/Plugin/Action/UnpublishByKeywordComment.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 123 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $account.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /src/Plugin/Action/AssignOwnerNode.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 139 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $account.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /src/Plugin/Action/UnpublishByKeywordNode.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 73 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $account.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /tests/action_form_ajax_test/src/Plugin/Action/ActionAjaxTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 34 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $account.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Issue fork action-3508897

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

enchufe created an issue. See original summary.

enchufe’s picture

Assigned: enchufe » Unassigned
Status: Needs work » Needs review
andypost’s picture

Not sure we need to make action_id typed only in one place but it's not required

enchufe’s picture

You are right, even though it is not an explicit PHP 8.4 warning I thought it would be a good contribution.
I have removed the variable typing and defined in @docs that this is a mixed type.

andypost’s picture

Status: Needs review » Reviewed & tested by the community

Going to merge soon, would be great to fix phpstan/phpcs before making release

  • andypost committed b2b86154 on 1.x authored by enchufe
    Issue #3508897 by enchufe, andypost: PHP 8.4 implicit nullable...
andypost’s picture

Status: Reviewed & tested by the community » Fixed

Fixed pipeline and merged, thank you

andypost’s picture

Related issues: +#3509218: Fix tests for 11.x

filed follow-up

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.