Closed (fixed)
Project:
Group
Version:
4.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
25 Feb 2025 at 13:43 UTC
Updated:
28 May 2025 at 13:49 UTC
Jump to comment: Most recent
Problem/Motivation
Core now has support for OOP hooks. As they are automatically converted into autowired services, it means we can empty out the module file and use proper dependency injection rather than \Drupal::service() calls.
Steps to reproduce
N/A
Proposed resolution
Implement OOP hooks
Remaining tasks
Implement OOP hooks
User interface changes
N/A
API changes
N/A. Procedural hooks will be gone, but hook implementations are not considered API
Data model changes
N/A
Issue fork group-3508876
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
kristiaanvandeneyndeShould probably kill _group_relation_type_manager() now, but that requires a CR.
Comment #4
kristiaanvandeneyndeShould go over each hook manually to see if it still works.
Follow-ups:
Comment #5
kristiaanvandeneyndePushed a commit that uses hook ordering and the new theme initial preprocess callbacks. The entire module file is gone now and I've bumped minimum required version to 11.2. That last bit may make tests fail as we don't have an official 11.2 release yet.
Comment #6
kristiaanvandeneyndeTests are failing on me forgetting to convert tokens.inc and views.inc, also need to tackle submodules still.
Comment #7
kristiaanvandeneyndeAll green for next minor, so will commit after one final round of reviewing the code and threads.
Comment #10
kristiaanvandeneyndeGoing to commit this in its current shape. Can still make changes before release if the meta in core evolves regarding best practices.