Problem/Motivation

Hi, I noticed that the logo upload currently supports only the following extensions: png, gif, jpg, jpeg, apng, svg.

Could you allow support for WEBP as well? Additionally, can you make it configurable so users can define allowed extensions dynamically?

Thanks

Issue fork gin-3508555

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ujjval kumar jha created an issue. See original summary.

ujjval kumar jha’s picture

ujjval kumar jha commented
Issue summary: View changes

kostask made their first commit to this issue’s fork.

kostask’s picture

kostask commented
Status: Active » Needs review

I have created a MR that adds support for webp images.

bserem’s picture

bserem commented
Assigned: Unassigned » bserem

checking

kostask opened merge request !600

bserem’s picture

bserem commented
Assigned: bserem » Unassigned
Status: Needs review » Reviewed & tested by the community

Code review pass, all are looking ok.

Testing without the fix against current 4.0.x I couldn't upload a WebP logo.
Applying the fix I could upload a WebP logo and I could see it in the sidebar.

Approved.
Well done

kostask’s picture

kostask commented

Here is the change record 'file_validate and related functions are deprecated and replaced with file.validator service and Constraint plugins': https://www.drupal.org/node/3363700

ujjval kumar jha’s picture

ujjval kumar jha commented

Let me know changes has been merged?
Then will close it

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Needs work

Sorry for the late reply here :(

This needs a rebase and a 5.0.x branch

Thanks! :)