I have a D6 installation with OG and Location. The nodes that are edited collaboratively keep revisions, but I am having problems showing the differences.

When I choose two revisions and hit on Show Diff button, I get a fatal error with this message.

Cannot use object of type stdClass as array in /[...]/sites/all/modules/location/location.module on line 1436

When going to another page from that error, I get the following warning:

warning: Missing argument 3 for location_diff() in /[...]/sites/all/modules/location/location.module on line 1345.

Any idea?

Comments

steckels00’s picture

Version: 6.x-3.0 » 5.x-3.0

I am seeing the same issue in 5.x-3.0 with all of our content types, just a different line number. As it's the same issue/different version thought I'd post this as well. Using Drupal 5.14

Cannot use object of type stdClass as array in /[...]/sites/all/modules/location/location.module on line 1412

bdragon’s picture

Title: Error related to location_diff() when trying to show diff between revisions » [master]Error related to location_diff() when trying to show diff between revisions
Assigned: Unassigned » bdragon
Status: Active » Fixed

Marking as master.

This is now fixed, I had to rename the api function location_diff() to do it, so I changed location_api_variant() to 2.

http://drupal.org/cvs?commit=162978
http://drupal.org/cvs?commit=162979
http://drupal.org/cvs?commit=162982

bdragon’s picture

bdragon’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

fgm’s picture

Version: 5.x-3.0 » 6.x-3.0-rc2
Status: Closed (fixed) » Active

Same problem here again in 6.x.

bdragon’s picture

Version: 6.x-3.0-rc2 » 6.x-3.x-dev
Status: Active » Fixed

Uh, no, all 3 branches were fixed simultaneously, it's a post rc2 change. Actually, it's a post 1.0 change too.

bdragon’s picture

bdragon’s picture

richard.e.morton’s picture

so this is fixed in 3.x, when will this be released?
can/should the dev be used on a beta site?
thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Rainy Day’s picture

Problem persists in 6.x-3.0, but appears to be fixed in 6.x-3.1-rc1.

richard.e.morton’s picture

excellent, RC1 works fine now with diff. thanks very much on your work with this.

subsequent to swapping the location module versions but prior to updating db the following error does show when completing a difference on revisions (although the rest of the output seems to be correct):

warning: Missing argument 3 for location_diff() in /var/www/vhosts/nafof.org.uk/httpdocs/sites/all/modules/location/location.module on line 1345.

Thanks again

Richard
WebMaster of NaFoF - Multi Activity and Social clubs in the UK

Marko B’s picture

I am getting similar error with latest dev

Fatal error: Cannot use object of type stdClass as array in C:\wamp\www\travel\sites\all\modules\location\location.module on line 1436
array(4) { ["type"]=> int(1) ["message"]=> string(43) "Cannot use object of type stdClass as array" ["file"]=> string(61) "C:\wamp\www\travel\sites\all\modules\location\location.module" ["line"]=> int(1436) } n/a

yesct’s picture

Status: Closed (fixed) » Active

deepM, Please confirm the date of the recent dev version you are using, and provide a step by step, starting with a blank test site, with how to reproduce this bug. That will really help others be able to test this out and help find a solution. Thanks.

legolasbo’s picture

Issue summary: View changes
Status: Active » Closed (outdated)

Closing old D6 issues as D6 is end of life