Problem/Motivation

Right now, search_current_language only supports the core search.node_search plugin.

There are contrib modules who also provide search page plugins.
- https://drupal.org/project/search_exclude

Saw an issue on the search_exclude project #3343993: Not compatible with search_current_language module

Steps to reproduce

Install search_exclude and configure as described on the project page.
Install search_current_language module and set multiple languages.
Install devel_generate module and create a lot of demo content of varying languages.
Run cron to ensure everything is indexed.
Attempt to use your search exclude search page, and see that your searches are not filtered by the current language.

Proposed resolution

Add configuration for enabling on any search page plugin. (Or just support all automatically)

Remaining tasks

Merge request

User interface changes

Search page plugins other than core now utilize this module's functionality.

API changes

N/A

Data model changes

Depends on implementation.

Comments

trackleft2 created an issue. See original summary.

jmauricio’s picture

Assigned: Unassigned » jmauricio
Status: Active » Needs work

I will look into this as soon as i have some time

  • jmauricio committed 2b4ce915 on 1.0.x
    Issue #3507577 by trackleft2, jmauricio: Support additional search page...
jmauricio’s picture

Assigned: jmauricio » Unassigned
Status: Needs work » Needs review

Pushed to 1.0.x, can you test it please?

trackleft2’s picture

Status: Needs review » Needs work
jmauricio’s picture

@trackleft2 any comments?

trackleft2’s picture

jmauricio’s picture

ok, i answered there also.

trackleft2’s picture

Status: Needs work » Reviewed & tested by the community

I've tested this with search exclude module and it works perfectly AFAICT. RTBC.

trackleft2’s picture

I've added a PHPUnit Functional test in the search_exclude module to test the integration.
See: https://git.drupalcode.org/project/search_exclude/-/merge_requests/14/diffs

See test passed: https://git.drupalcode.org/issue/search_exclude-3343993/-/jobs/4521966

jmauricio’s picture

Status: Reviewed & tested by the community » Fixed

1.0.2 release

jmauricio’s picture

Status: Fixed » Closed (fixed)