Problem/Motivation

Once #3483209: Navigation leverage icon core API provides a new icon set for Navigation, the approach used by NavigationLinkBlock to define icon might need to be reviewed to make use of the new Icon API instead of the current magic class pattern.

Steps to reproduce

Proposed resolution

TBD

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Comments

plopesc created an issue. See original summary.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Title: [PP-1] Integrate the new Navigation Icon API with NavigationLinkBlock » Integrate the new Navigation Icon API with NavigationLinkBlock
Status: Postponed » Active

This issue is still valid. We continue relying on the magic class pattern approach here. In my mind, ideally, we would allow the user to configure a icon_pack_id and icon_id pair for the block plugin that would get used in rendering it. That's an awkward UX experience, given core doesn't have any icon widgets, but, it could be left to contrib to make it better, and/or if/when core adopts a widget for icons.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.