Problem/Motivation

When restoring and purging entities, I recommend we add the following log messages, similar to Drupal core's node module.

  • [bundle]: restored [entity:title].
  • [bundle]: purged [entity:title].

Log message type: trash
Severity: info

Issue fork trash-3506874

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

chrisck created an issue. See original summary.

anish.ir’s picture

Assigned: Unassigned » anish.ir

Working on it.

anish.ir’s picture

Assigned: anish.ir » Unassigned
Status: Active » Needs review
StatusFileSize
new44 KB
new62.14 KB

Hey,

Added both the logger messages. Attaching screenshots for better understanding.
Please have a look.
Thanks !

amateescu’s picture

Status: Needs review » Needs work

The node log message works nicely because it's on the content logger channel, but if we're using the trash channel we need to specify the entity type as well.

NW for that and for failing tests.

anish.ir’s picture

Status: Needs work » Needs review
StatusFileSize
new15.83 KB

Hey @amateescu,
Thanks for the feedback!

I've updated the logger message to include the entity type, ensuring consistency with the trash channel.
Additionally, I have resolved the failing pipeline tests by properly injecting dependencies. The tests are working fine now.

Attaching screenshot for the logger message and reference.

Let me know if any further adjustments are needed!
Thanks !

  • amateescu committed a8fa49af on 3.x authored by anish.ir
    Issue #3506874 by anish.ir, amateescu, chrisck: Add log message for...
amateescu’s picture

Status: Needs review » Fixed

Cleaned up the MR and merged into 3.x, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.