Problem/Motivation

Currently there is to many duplicate css inside compiled files.

eg fontfaces of font-awesome are defined in 4 different files.
--clr-spot-1 is defined in 3 different files.
.button styles are defined in 3 different files.

This should be cleaned up, and fixed with dependencies on libraries. This will reduce load times and we will have compacter css files.

Proposed resolution

Check why there are so many different files and if we all need them.
If more then one file needs the same code, this should be fixed with libraries en dependencies.
eg: if you need the font-faces in more then one place, make sure gulp generates it 1 time, and add dependencies to the libraries.

Remaining tasks

//

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

al0a created an issue. See original summary.

al0a’s picture

Version: 3.x-dev » 4.x-dev

al0a’s picture

Status: Active » Needs review

There has been a lot of cleanup in the 3.x branch since the removal of storybook. The last tings I saw where css variables.

So for the main css variables, I created a new library and added dependencies to it.

For content-blocks, I removed them form adding to the print version, since they are already in the main one that gets included on any media type.

Regarding QA: check the css dist folder files.

rubendello made their first commit to this issue’s fork.

rubendello’s picture

Status: Needs review » Fixed

Review the MR, fixed conflicts & merged to 4.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.