Closed (fixed)
Project:
Experience Builder
Version:
0.x-dev
Component:
Page builder
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Feb 2025 at 21:48 UTC
Updated:
18 Mar 2025 at 10:49 UTC
Jump to comment: Most recent

Comments
Comment #4
omkar-pd commentedIn AutoSaveManager.php there is a @todo
Update label from incoming entity data once it existsfor label.https://git.drupalcode.org/project/experience_builder/-/blob/0.x/src/Aut...
Is it the right change?
Comment #5
wim leersI believe this is indeed the correct place/approach, but it should not hardcode
title[0][value].See the MR for #3505118: The status badge should indicate if there are changes to the page at https://git.drupalcode.org/project/experience_builder/-/merge_requests/6... for the correct generalized approach, which looks like this:
Comment #6
wim leersComment #7
omkar-pd commentedThanks @wim,
I'll look into it.
Comment #8
wim leersWhat do you mean? 🤔
Comment #9
omkar-pd commentedSorry, I meant 'I will look into it.' I mistyped in a hurry.
Comment #10
omkar-pd commentedI've implemented the changes as mentioned in #5. Keeping this in "Needs Review" since tests are still required, allowing someone else to pick it up and continue
Comment #12
akhil babuThis warning was appearing in logs while running the tests. So I have updated the AutoSaveManager::save() method to check if $data["entity_form_fields"] exists or not.
Please review
Comment #13
lauriiiLooks like there's test coverage already. The MR needs a rebase still though.
Comment #14
nagwani commentedComment #16
tedbowIf tests pass, I think this is good
Comment #18
tedbowComment #19
tedbowComment #20
nagwani commented