Problem/Motivation

While applying any recipe in a site which has rocketship installed in it. The recipe runner throws an unsupported key error for rocketship_seo.seo_fields, rocketship_seo.seo_title & rocketship_seo.seo_description configs.

Steps to reproduce

Apply any recipes in a site which has rocketship_core installed.

Proposed resolution

Create a schema.yml file for the said configs.

Issue fork rocketship_core-3506165

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

abhisekmazumdar created an issue. See original summary.

abhisekmazumdar opened merge request !148

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Assigned: abhisekmazumdar » Unassigned
Status: Active » Needs review

This is ready for review.

l_vandamme’s picture

l_vandamme commented
Status: Needs review » Needs work

The seo_fields property is not a mapping, it is a list (potentially empty) of fields that need to be in the SEO wrapper.

https://git.drupalcode.org/project/rocketship_core/-/merge_requests/148/... needs to be changed

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Status: Needs work » Needs review

@l_vandamme I hope keeping the seo_fields as a sequence type will be fine. I have updated the MR; please review.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Status: Needs review » Reviewed & tested by the community

I think the schema is correct now

  • 90fca173 committed on 6.2.x 
    fix: #3506165 The third party setting config for rocketship_seo needs to...
l_vandamme’s picture

l_vandamme commented
Status: Reviewed & tested by the community » Fixed

Committed on 6.2.x and released as part of https://www.drupal.org/project/rocketship_core/releases/6.2.4

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

l_vandamme’s picture

l_vandamme commented
Status: Fixed » Closed (fixed)