Overview

Page title should not be a required block. As described in #3489899: Add support for global regions, messages and main content are special cases. Title has some specialness to it but we are not considering it as such for now.

Proposed resolution

Page title should not be required.

User interface changes

Issue fork experience_builder-3505872

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Title: Page title should not be required » Page title block should not be required

I read this and was confused, thinking it was the Page entity title, adding block to issue title

wim leers made their first commit to this issue’s fork.

wim leers opened merge request !641

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Page builder » Config management
Assigned: Unassigned » lauriii
Status: Active » Needs review
Issue tags: +validation, +Configuration schema

Thanks, I was similarly confused.

@lauriii: Are you saying it's okay for the page title to not appear anywhere? Because if so, that's a trivial change 😄

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Needs work

Yes, we should allow that!

This looks good except Cypress tests are failing. 👍

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: lauriii » Unassigned
Related issues: +#3501600: Split 1 PageTemplate config entity into N PageRegion config entities, +#3485917: `ComponentTreeMeetRequirements` constraint validator must be updated now that Blocks-as-Components are supported + make PageTemplate render main content!

Thanks for confirming.

Re-testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community

Re-testing again. Locally it passes. 😬

  • wim leers committed 023d4220 on 0.x 
    Issue #3505872 by wim leers, lauriii, mglaman: Page title block should...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

@lauriii: I proposed to do something similar for the "messages" block over at #3501600-17: Split 1 PageTemplate config entity into N PageRegion config entities.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.