Module clean-up and new features [#350490]

- Added permissions.
- User can now edit her terms.
- You can assign\ remove a vocabualry from a group right inside the admin/taxonomy page.
- CRUD api, in preparation for Rules integration..
- Vocab overview is now a form, allowing easier form_alter().
- Breadcrumb and redirection is a little nicer.
- Clean-up comments, move functions to include files.

- TODO, and we'll be happy for some help on that is make the terms block dependent on Views.

Comment	File	Size	Author
#3	og_vocab.tar_.gz	13.11 KB	amitaibu
#2	og_vocab.tar_.gz	13.07 KB	amitaibu
#1	og_vocab.tar_.gz	12.79 KB	amitaibu
	og_vocab.tar_.gz	12.72 KB	amitaibu

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 23 December 2008 at 16:04

File	Size
og_vocab.tar_.gz	12.79 KB

And a minor fix to a an un-handled redirect.

Comment #2

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 24 December 2008 at 10:02

Status:

Active

» Needs review

File	Size
og_vocab.tar_.gz	13.07 KB

And here's an automatic workflow using the Rules module:
1) Use the attached module
2) Patch OG, to allow creating a group node ('Add group settings' action). #338919: Rules action - Add group node settings to content
3) Patch rules to allow taxonomy vocab actions. 'Add a new vocabulary' when a new group is created. #350831: Add taxonomy vocab actions
4) Assign vocabulary to the new created group.

In other words, every created group automatically gets its own vocab.

Comment #3

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 24 December 2008 at 10:30

File	Size
og_vocab.tar_.gz	13.11 KB

hmm, why can't i get it right on the first time ;)

Comment #4

moshe weitzman CreditAttribution: moshe weitzman commented 24 December 2008 at 13:28

Status:

Needs review

» Reviewed & tested by the community

After a quick read of og_vocab.module:

if (arg(0) == 'node' && is_numeric(arg(1)) && arg(2) == 'og') {. Can we avoid arg()? Same for $form['#redirect'] = 'node/'. arg(1) .'/og/vocab';
Just below that, try something like array_diff($form['content_types']['nodes']['#options'], $skip)
typo: vocabulry
Implementation of hook_term().. I think you mean hook_taxonomy
Feel free to expand the README with more ideas for the admin about how to use this, and any new info thats helpful.

I added Amitaibu as a committer. He is welcome to commit this after acting on this review.