Problem/Motivation

After upgrade in
https://www.drupal.org/project/drupal/issues/3493146#comment-15972700

we got new version 4 of chokidar
but we ignored its changelog:
https://github.com/paulmillr/chokidar?tab=readme-ov-file#upgrading

Steps to reproduce

run core `yarn watch:css`
change any *.pcss.css file
watch not works.

Remaining tasks

Test on Linux and Windows

Issue fork drupal-3504265

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

finnsky created an issue. See original summary.

finnsky’s picture

finnsky commented
Issue summary: View changes

Updated according https://github.com/paulmillr/chokidar?tab=readme-ov-file#upgrading

added usePolling: true because on macos i had lot of errors like:

yarn run watch:css
node:internal/fs/watchers:207
      const error = new UVException({
                    ^

Error: EMFILE: too many open files, watch
    at FSWatcher._handle.onchange

finnsky opened merge request !11108

finnsky’s picture

finnsky commented
Version: 11.1.x-dev » 11.x-dev

finnsky closed merge request !11108

finnsky changed the visibility of the branch 3504265-yarn-watch-task to hidden.

finnsky opened merge request !11109

finnsky’s picture

finnsky commented
Status: Active » Needs review
ksenzee’s picture

ksenzee
she/her
commented

I can reproduce the error on Ubuntu 22.04 (hm I should probably upgrade), and the MR fixes it. Not sure I'm the best person to review the actual diff, but it looks reasonable to me.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

@ksenzee fixed it for me too. Think it's fine to mark

nod_ closed merge request !11109

  • nod_ committed eeaa76ed on 11.1.x 
    Issue #3504265 by finnsky, ksenzee, smustgrave: Yarn watch task broken...

  • nod_ committed cce7d977 on 11.x 
    Issue #3504265 by finnsky, ksenzee, smustgrave: Yarn watch task broken
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed eeaa76e and pushed to 11.1.x. Thanks!

The cherry pick is not clean on 10.5.x

smustgrave’s picture

smustgrave commented
Version: 11.x-dev » 10.5.x-dev

Believe the 10.5 window is still open

smustgrave opened merge request !12183

smustgrave’s picture

smustgrave commented
Status: Patch (to be ported) » Needs review

Backported

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Was a clean backport I believe.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work

Test failure, might just need rerunning?

quietone made their first commit to this issue’s fork.

quietone’s picture

quietone commented
Version: 10.5.x-dev » 10.6.x-dev
Status: Needs work » Needs review

Updated MR to 10.6 and tests are passing.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems to be good rebase.

  • xjm committed 1bf26ca8 on 10.6.x 
    Issue #3504265 by finnsky, smustgrave, ksenzee, nod_: Yarn watch task...

  • xjm committed 3a84566d on 10.5.x 
    Issue #3504265 by finnsky, smustgrave, ksenzee, nod_: Yarn watch task...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

I tested manually and confirmed that:

  1. yarn watch:css works on 11.x with the above fix that was already committed.
  2. yarn watch:css does not work on 10.5.x HEAD.
  3. yarn watch:css does work on 10.5.x HEAD with the patch applied:
    [ayrton:core | Sun 16:28:48] $ yarn watch:css
yarn run v1.22.22
warning ../../../package.json: No license field
$ node ./scripts/css/postcss-watch.js
[16:29:28] Watching '**/*.pcss.css' for changes.
[16:29:42] 'themes/claro/css/theme/field-ui.admin.pcss.css' is being processed.
[16:29:42] 'themes/claro/css/theme/field-ui.admin.pcss.css' is finished.

Committed the backport to 10.6.x and cherry-picked it to 10.5.x as a major development process bugfix. Thanks everyone!

xjm closed merge request !12183

xjm changed the visibility of the branch 3374901-backport-10.5 to hidden.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 10.6.x-dev » 10.5.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.