Problem/Motivation

After #3494332: Functional Javascript tests are silently skipped on Gitlab CI due to selenium standalone configuration got fixed the test-only tests were still failing. I've had a MR for #3485202: Change the element wrapping the title in dialogs from span to heading element I initially ran into the skipped tests problem with. After rebasing to the latest changes in 11.x i got failing test-only tests, but the fail was not about the tests but about (see https://git.drupalcode.org/issue/drupal-3485202/-/jobs/4151589):

Caused by
WebDriver\Exception\CurlExec: Could not resolve host: selenium

Steps to reproduce

Proposed resolution

Per suggestion of @catch on Slack i've tried changing with-chrome to with-selenium-chrome in the pipeline definitions in the gitlab-ci pipeline.yml. I've tested it in the aforementioned MR. The job failed as well https://git.drupalcode.org/issue/drupal-3485202/-/jobs/4155477 but this time due to the actual test: 

$dialog_title = $link1_dialog_div->find('css', "h1.ui-dialog-title:contains('AJAX Dialog & contents')");
$this->assertNotNull($dialog_title);

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3502629

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rkoller created an issue. See original summary.

rkoller opened merge request !11021

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Assigned: rkoller » Unassigned
Status: Active » Needs review
rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Title: Change the pipline service from with-chrome to with-selenium-chrome » Change the test-only pipeline service from with-chrome to with-selenium-chrome
ironnuts’s picture

ironnuts commented

@rkoller Can you look at line 89 of https://git.drupalcode.org/project/drupal/-/merge_requests/11003/diffs

I mean it looks like you might need to edit line 89 of the gitlab.yml. Not sure you edited the right line?

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented

isn't line 89 defining the with-selenium-chrome test? but what the problem was was that test-only changes used with-chrome instead. and this MR changes using with-selenium-chrome for the test-only tests instead of with-chrome.

ironnuts’s picture

ironnuts commented

Ok, I see. I see pipeline is green, now.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

If I understand correctly, with-chrome means to use the service (Docker container) $_CONFIG_DOCKERHUB_ROOT/chromedriver:production, and with-selenium-chrome: means to use the service selenium/standalone-chrome:127.0. (Presumably the version will be updated as needed.)

After the change in MR 11021, the only tests in pipeline.yml using with-chrome will be 🖱️️️ PHPUnit Functional Javascript (non W3C legacy) and 🚲 Performance tests.

I notice there is also a 🩹 Test-only changes job defined in pipeline-test-only.yml. That job already has the service selenium/standalone-chrome:latest.

I am not at all sure how all this fits together, but

  1. The change in MR 11021 (switching to selenium-standalone-chrome looks like it will make the two jobs more consistent.
  2. I am surprised that there are two jobs with so much in common and yet not identical.
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

I am also not sure why we have two "test only" jobs defined in separate pipelines but that's out of scope here.

Eventually the "non W3C" with-chrome will go away and we will only use the Selenium drivers, so this is a good step towards that.

  • catch committed de85d081 on 11.x 
    Issue #3502629 by rkoller: Change the test-only pipeline service from...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Opened #3504306: Reconcile test-only jobs to look at the two test-only jobs.

Committed/pushed to 11.x, thanks!

catch closed merge request !11021

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.