Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
other
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Jan 2025 at 23:09 UTC
Updated:
11 Feb 2025 at 11:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
quietone commentedComment #4
oily commented@quietone I was going to run the command in the 'steps to reproduce'. I notice the command starts:
(11.x)$ git grep. Is that correct? Or should the 'git' be removed?Anyway, if someone pulls the issue branch to local then switches between the 11.x branch and this branch and the command returns 0 and 8 lines respectively, will that be sufficient as a review?
Comment #5
oily commentedThis is running the git grep command on the current 11.x branch
Comment #6
oily commentedRunning the git grep command on the MR. It returns 2 lines instead of 8.
Comment #7
oily commentedIt seems from the 'proposed resolution' that both these files are expected to be returned by the command. There seem to be 1 or 2 of the other lines that should be returned but that are not. But so long as that is not an issue the issue seems ready. Changing to RTBTC.
Comment #8
oily commentedComment #9
dcam commentedI'm not trying to be a pedant, but isn't this issue implementing the short array syntax, not removing it? I'm only asking because I opened this issue to see if there was some change in coding standards that I wasn't aware of.
Comment #10
oily commentedComment #14
nod_Committed 523cbdf and pushed to 11.x. Thanks!
Comment #15
nod_