Problem/Motivation

The CI is not green, making reviewing the issues too hard

Steps to reproduce

See any recent pipeline for any MR

Proposed resolution

Fix the CI

Remaining tasks

Check and fix the CI jobs

User interface changes

None

API changes

None

Data model changes

None

Issue fork svg_image_field-3501734

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

taran2l created an issue. See original summary.

taran2l opened merge request !36

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Title: Make CI green again » [PP-1] Make CI green again
Status: Active » Postponed

Blocked by #3482121: Error uploading svg from the media tab (The "file_validate_extensions" plugin does not exist)

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Title: [PP-1] Make CI green again » Drupal 11 compatibility fixes
Status: Postponed » Active

I'm going to retitle this so that it makes more sense in our release notes because there are several additional changes that have to do with groundwork for getting Drupal 11 working, namely DDEV, that have to be committed first before I can properly test and review the other issue.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

All the validations are green on https://git.drupalcode.org/project/svg_image_field/-/pipelines/404226

the only remaining errors are from phpunit, which I believe are directly caused by #3482121: Error uploading svg from the media tab (The "file_validate_extensions" plugin does not exist).

Drupal\Tests\svg_image_field\Functional\Plugin\Field\FieldFormatter\SvgImageFieldFormatterTest::testDisplayImage
Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Save" not found.

The save button isn't found because the image cannot be uploaded due to the validator problem.

I'm going to go ahead and merge this one, then rebase #3482121 and let those phpunit tests run there again to see if they pass.

  • jwilson3 committed 454081d3 on 2.3.x authored by taran2l 
    Issue #3501734 by taran2l, jwilson3: Drupal 11 compatibility fixes
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Active » Fixed

tentatively marking this one fixed, crossing fingers for green on #3482121.

Thanks @taran2l

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

The Drupal 11 compatibility fixes here have been included in the latest SVG Image Field module release 2.3.4

We have a follow-up issue to bring about additional Drupal 11.2.x compatibility due to deprecations:

#3501879: Drupal 11.2.x compatibility