Core migration issues

Next video meeting 2025-04-24

Hello all, it’s time for the biweekly migration subsystem meeting. The meeting will take place in slack in various threads. This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every second Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. #3456078: [meeting] Migrate Meeting 2024-07-18 2100Z)See the parent issue for an idea of the typical agenda.
➤Transcript will be exported and posted to the agenda issue. For anonymous comments, start with a 👤 emoji. To take a comment or thread off the record, start with a 🚫 emoji.

0️⃣ Who is here today?

benjifisher Hi! I will be multi-tasking for the first 30 minutes of the meeting.
Stephanie Here today. Sort of multitasking
Dan Davis Present
heddn Here!
godotislate :wave:
quietone Catching up

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

heddn #3069776: SQL source plugins: allow defining conditions and join in migration yml and specifically next steps for #2833060: SqlBase::prepareQuery() should be called also on count

2️⃣ Action items. To be added later.

benjifisher Update #3498915: Move content_entity source plugin to migrate module: @benjifisher
benjifisher Open issues to discuss process plugins and destination plugins, when removing the migrate_drupal module: @quietone
benjifisher #3258581: Move I18nQueryTrait from content_translation to migrate_drupal: @godotislate, @benjifisher
benjifisher Review #3069776: SQL source plugins: allow defining conditions and join in migration yml.)

3️⃣ Statistics

benjifisher All open: 353.
benjifisher Fixed in the last 2 weeks: 1 (not counting issues for meetings).
benjifisher RTBC: 4, 1 of which is Major.
benjifisher NR: 2, both Normal priority.
benjifisher Needs subsystem maintainer review: 9
benjifisher Google sheet for recording stats: https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi...

4️⃣ Comment in this thread if you are looking for ways to contribute. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

5️⃣ Previous minutes.

benjifisher Already Fixed: #3495036: [meeting] Migrate Meeting 2025-01-02

6️⃣ Announcements

7️⃣ Steps to remove the migrate_drupal module. (edited) 

benjifisher Move content_entity source plugin to migrate module
benjifisher #3498915: Move content_entity source plugin to migrate module
benjifisher This issue is also high on my to-do list. I opened the issue, and it is currently NW. I will update it soon.
quietone I hope to open issues to discuss the destination plugins and process plugin in the next few days.

8️⃣ Move I18nQueryTrait from content_translation to migrate_drupal

benjifisher #3258581: Move I18nQueryTrait from content_translation to migrate_drupal
benjifisher This issue is one of my top to-dos. It was RTBC, set back to NW. I have been reviewing it, so if someone else will make the requested changes, then I will review it promptly.
benjifisher This issue is a blocker for #3421014: Convert MigrateSource plugin discovery to attributes
benjifisher Volunteer needed: maybe @godotislate or @zniki.ru?
godotislate I'll see if I can take a look later
benjifisher I see that you updated it. Thanks! I need some sleep now, but I will review it as soon as I can.

9️⃣ [PP-1]: SQL source plugins: allow defining conditions and join in migration yml

benjifisher #3069776: SQL source plugins: allow defining conditions and join in migration yml
benjifisher This issue is postponed on #2833060: SqlBase::prepareQuery() should be called also on count  (SqlBase::prepareQuery() should be called also on count).
heddn I'd really like to see the base feature here land. But it seems blocked on the count query being off.
heddn @mikelutz (he/him) posted some thoughts, but they were more just options then specific guidance. personally, I'd like to adjust the count to use the query post prepareQuery and call it good.
heddn but :shrug:
benjifisher @mikelutz (he/him): Can you either give some more explicit guidance or else agree that this issue is good enough?
mikelutz (he/him) I won’t block it if you both agree it’s fine to just call preparequery in the count, It just feels a little icky to me because we have query modifiers in several places and it’s not at all clear where things should be to be or not to be included in the count.
mikelutz (he/him) But the issue as it stands is no worse than what we have now, it’s just not much better.
heddn either way, we should open a docs? issue to clarify and clean things up. but clean-up takes time.
benjifisher Alternatively, could we decide that the other issue can be fixed now instead of postponing it on this one?
heddn no, I don't like that at all. its why I want to have the count adjusted for the prepareQuery. we need to update count or we're going to have lots of questions.
heddn if you build your entire query via yaml, then you'd expect the count to adjust to that query.
benjifisher I am inclined to fix this bug without a lot of restructuring, implement the feature request, and then open a separate issue to implement query tag alters. (That is my shorthand for Mike's long Comment #46.)
heddn folks woulnd't care about the internal workings of things and some great explanation of why this was introduced via a prepareQuery this couldn't adjust the count... they would look at us and say they don't understand. (edited)
heddn then ask again, why is the count off? (edited)
heddn no disagreement about Mike's feeling icky though. :1000: (edited)
heddn but I feel more Icky with the executable. so if we are trying to do clean-up, we should try to make that more sane.
benjifisher I think we have consensus. Now, we just need someone to review the current MR.
benjifisher Thanks for raising this thread, @heddn!
benjifisher Sorry, we do not have time in this meeting to clean up the executable. The meeting is limited to 24 hours. ;)
heddn kk. its green. and the MR is fairly short. any volunteers 🙋 :question:
benjifisher Definitely maybe. But I have to get to my day job now.

1️⃣0️⃣ Wrap up

benjifisher Thanks for participating! I will update 2️⃣. Please continue to add comments in the threads. In 1-7 days, we will post a transcript for today's meeting.

Comments

benjifisher created an issue. See original summary.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Active » Needs review
benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Issue summary: View changes
benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Issue summary: View changes
benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Title: [meeting] Migrate Meeting 2025-01-30 2100Z » [meeting] Migrate Meeting 2025-01-16 1400Z
Parent issue: #3497391: [meeting] Migrate Meeting 2025-01-30 2100Z » #3495036: [meeting] Migrate Meeting 2025-01-02

Oops: I meant to update #3500283: [meeting] Migrate Meeting 2025-01-16 1400Z, not this issue.

I think I will swap the titles.

smustgrave credited godotislate.

smustgrave credited heddn.

smustgrave credited mikelutz.

smustgrave credited quietone.

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Threads appear to be captured. Credited users.

smustgrave’s picture

smustgrave commented

Oops forgot to save benjifisher

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.