Problem/Motivation

Drush commands do not accept options.

Steps to reproduce

drush ecdl:dlet paragraph en --preserve-languages=en
Prints The "--preserve-languages" option does not accept a value.

drush ecdl:dlet paragraph en --preserve-legacy-default-language=TRUE
Prints The "--preserve-legacy-default-language" option does not accept a value.

The same for ecdl:cdl command.

Environment: Drupal 10.4. Drush 12.4.3.

CommentFileSizeAuthor
#4 entity_change_default_language-accept_options-3499979-2.patch3.07 KBsinn
#3 avtobus-ru.po65 bytessinn

Issue fork entity_change_default_language-3499979

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sinn created an issue. See original summary.

sinn opened merge request !8

sinn’s picture

sinn commented
Status: Active » Needs review
StatusFileSize
new avtobus-ru.po65 bytes

MR and patch is available for review.

sinn’s picture

sinn commented
StatusFileSize
new entity_change_default_language-accept_options-3499979-2.patch3.07 KB

MR and patch is available for review.

sinn’s picture

sinn commented
nginex’s picture

nginex commented
Version: 1.0.1 » 1.x-dev
Status: Needs review » Reviewed & tested by the community

Patch works like a charm, thanks

facine made their first commit to this issue’s fork.

  • facine committed 47e2ba70 on 1.x authored by sinn 
    Issue #3499979: Accept options in drush commands.
facine’s picture

facine commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nginex’s picture

nginex commented

Hi @facine,

The patch was working fine, but your change ruined it https://git.drupalcode.org/project/entity_change_default_language/-/merg..., so it stopped working

Could you please revert your commit and create a new release? because latest release currently does not work.

Besides, you can't just use 'bundle' in the query condition as in different entity types it's different, get it dynamically from the entity type as entity key