Fix CliCommandWrapper Constructor to Require LibraryDiscoveryInterface [#3499886]

Problem/Motivation

I had a working D10 project with ckeditor_media_embed:2.x-dev
After I upgraded the project to D11 and tried to clear caches or updb, I receive following error:

[error]  TypeError: Drupal\ckeditor_media_embed\Command\CliCommandWrapper::__construct(): Argument #1 ($libraryDiscovery) must be of type Drupal\Core\Asset\LibraryDiscovery, Drupal\Core\Asset\LibraryDiscoveryCollector given, called in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\ckeditor_media_embed\Command\CliCommandWrapper->__construct() (line 69 of /var/www/html/web/modules/contrib/ckeditor_media_embed/src/Command/CliCommandWrapper.php) #0 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(259): Drupal\ckeditor_media_embed\Command\CliCommandWrapper->__construct()
#1 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#2 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#3 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#4 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#5 /var/www/html/vendor/drush/drush/src/Runtime/LegacyServiceInstantiator.php(289): Drupal\Component\DependencyInjection\Container->get()
#6 /var/www/html/vendor/drush/drush/src/Runtime/LegacyServiceInstantiator.php(253): Drush\Runtime\LegacyServiceInstantiator->resolveFromContainer()
#7 [internal function]: Drush\Runtime\LegacyServiceInstantiator->resolveArgument()
#8 /var/www/html/vendor/drush/drush/src/Runtime/LegacyServiceInstantiator.php(223): array_map()
#9 /var/www/html/vendor/drush/drush/src/Runtime/LegacyServiceInstantiator.php(193): Drush\Runtime\LegacyServiceInstantiator->resolveArguments()
#10 /var/www/html/vendor/drush/drush/src/Runtime/LegacyServiceInstantiator.php(167): Drush\Runtime\LegacyServiceInstantiator->instantiateObject()
#11 /var/www/html/vendor/drush/drush/src/Runtime/LegacyServiceInstantiator.php(117): Drush\Runtime\LegacyServiceInstantiator->create()
#12 /var/www/html/vendor/drush/drush/src/Runtime/LegacyServiceInstantiator.php(54): Drush\Runtime\LegacyServiceInstantiator->instantiateServices()
#13 /var/www/html/vendor/drush/drush/src/Boot/DrupalBoot8.php(242): Drush\Runtime\LegacyServiceInstantiator->loadServiceFiles()
#14 /var/www/html/vendor/drush/drush/src/Boot/DrupalBoot8.php(218): Drush\Boot\DrupalBoot8->addDrupalModuleDrushCommands()
#15 /var/www/html/vendor/drush/drush/src/Boot/BootstrapManager.php(211): Drush\Boot\DrupalBoot8->bootstrapDrupalFull()
#16 /var/www/html/vendor/drush/drush/src/Boot/BootstrapManager.php(397): Drush\Boot\BootstrapManager->doBootstrap()
#17 /var/www/html/vendor/drush/drush/src/Application.php(219): Drush\Boot\BootstrapManager->bootstrapMax()
#18 /var/www/html/vendor/drush/drush/src/Application.php(185): Drush\Application->bootstrapAndFind()
#19 /var/www/html/vendor/symfony/console/Application.php(284): Drush\Application->find()
#20 /var/www/html/vendor/symfony/console/Application.php(193): Symfony\Component\Console\Application->doRun()
#21 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run()
#22 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
#23 /var/www/html/vendor/drush/drush/drush.php(140): Drush\Runtime\Runtime->run()
#24 /var/www/html/vendor/bin/drush.php(119): include('...')
#25 {main}.

Steps to reproduce

Use this module + D11

Proposed resolution

See this issue for the ckeditor5_markdown_editor module which I believe to be very similar and has a working patch for that issue, that can be used as guidance on how to solve this issue I believe.

Comment	File	Size	Author
#3	ckeditor_media_embed-use-LibraryDiscoveryInterface-instead-of-LibraryDiscovery-3.patch	2.68 KB	flyke
#2	ckeditor_media_embed-use-LibraryDiscoveryInterface-instead-of-LibraryDiscovery-2.patch	1.59 KB	flyke

Comments

Comment #1

15 January 2025 at 10:08

flyke created an issue. See original summary.

Comment #2

flyke commented 28 January 2025 at 10:02

Status	File	Size
new	ckeditor_media_embed-use-LibraryDiscoveryInterface-instead-of-LibraryDiscovery-2.patch	1.59 KB

Added a patch to fix the issue.

Patch applies and fixes the error reported in the issue description.
But now there is a new error:

PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function Drupal\ckeditor_media_embed\Embed::__construct(), 7 passed in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 8 expected in /var/www/html/web/modules/contrib/ckeditor_media_embed/src/Embed.php:112
Stack trace:
#0 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(259): Drupal\ckeditor_media_embed\Embed->__construct()
#1 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#2 /var/www/html/web/modules/contrib/ckeditor_media_embed/src/Plugin/Filter/FilterCKEditorMediaEmbed.php(48): Drupal\Component\DependencyInjection\Container->get()
#3 /var/www/html/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php(21): Drupal\ckeditor_media_embed\Plugin\Filter\FilterCKEditorMediaEmbed::create()
#4 /var/www/html/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php(76): Drupal\Core\Plugin\Factory\ContainerFactory->createInstance()
#5 /var/www/html/web/core/lib/Drupal/Core/Plugin/DefaultLazyPluginCollection.php(81): Drupal\Component\Plugin\PluginManagerBase->createInstance()
#6 /var/www/html/web/core/modules/filter/src/FilterPluginCollection.php(76): Drupal\Core\Plugin\DefaultLazyPluginCollection->initializePlugin()
#7 /var/www/html/web/core/modules/filter/src/FilterPluginCollection.php(54): Drupal\filter\FilterPluginCollection->initializePlugin()
#8 /var/www/html/web/core/modules/filter/src/FilterPluginCollection.php(83): Drupal\filter\FilterPluginCollection->getAll()
#9 /var/www/html/web/core/modules/filter/src/Entity/FilterFormat.php(155): Drupal\filter\FilterPluginCollection->sort()
#10 /var/www/html/web/core/modules/filter/src/Entity/FilterFormat.php(167): Drupal\filter\Entity\FilterFormat->filters()
#11 /var/www/html/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php(355): Drupal\filter\Entity\FilterFormat->getPluginCollections()
#12 [internal function]: Drupal\Core\Config\Entity\ConfigEntityBase->__sleep()
#13 /var/www/html/web/core/lib/Drupal/Component/Serialization/PhpSerialize.php(14): serialize()
#14 /var/www/html/web/core/lib/Drupal/Core/Cache/DatabaseBackend.php(268): Drupal\Component\Serialization\PhpSerialize::encode()
#15 /var/www/html/web/core/lib/Drupal/Core/Cache/DatabaseBackend.php(211): Drupal\Core\Cache\DatabaseBackend->doSetMultiple()
#16 /var/www/html/web/core/lib/Drupal/Core/Cache/DatabaseBackend.php(195): Drupal\Core\Cache\DatabaseBackend->setMultiple()
#17 /var/www/html/web/core/modules/filter/filter.module(42): Drupal\Core\Cache\DatabaseBackend->set()
#18 /var/www/html/web/modules/contrib/webform/src/Plugin/WebformElement/ProcessedText.php(48): filter_formats()
#19 /var/www/html/web/modules/contrib/webform/src/Plugin/WebformElementBase.php(314): Drupal\webform\Plugin\WebformElement\ProcessedText->defineDefaultProperties()
#20 /var/www/html/web/modules/contrib/webform/src/Plugin/WebformElementBase.php(357): Drupal\webform\Plugin\WebformElementBase->getDefaultProperties()
#21 /var/www/html/web/modules/contrib/webform/src/Plugin/WebformElementBase.php(535): Drupal\webform\Plugin\WebformElementBase->hasProperty()
#22 /var/www/html/web/modules/contrib/webform/src/Entity/Webform.php(1826): Drupal\webform\Plugin\WebformElementBase->hasMultipleValues()
#23 /var/www/html/web/modules/contrib/webform/src/Entity/Webform.php(1839): Drupal\webform\Entity\Webform->initElementsRecursive()
#24 /var/www/html/web/modules/contrib/webform/src/Entity/Webform.php(1517): Drupal\webform\Entity\Webform->initElementsRecursive()
#25 /var/www/html/web/modules/contrib/webform/src/Entity/Webform.php(1301): Drupal\webform\Entity\Webform->initElements()
#26 /var/www/html/web/modules/contrib/webform_views/src/WebformSubmissionViewsData.php(236): Drupal\webform\Entity\Webform->getElementsInitializedAndFlattened()
#27 /var/www/html/web/core/modules/views/src/Hook/ViewsViewsHooks.php(163): Drupal\webform_views\WebformSubmissionViewsData->getViewsData()
#28 /var/www/html/web/core/modules/views/src/ViewsData.php(219): Drupal\views\Hook\ViewsViewsHooks->viewsData()
#29 /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(307): Drupal\views\ViewsData->Drupal\views\{closure}()
#30 /var/www/html/web/core/modules/views/src/ViewsData.php(218): Drupal\Core\Extension\ModuleHandler->invokeAllWith()
#31 /var/www/html/web/core/modules/views/src/ViewsData.php(142): Drupal\views\ViewsData->getData()
#32 /var/www/html/web/core/modules/views/src/ViewExecutable.php(1050): Drupal\views\ViewsData->get()
#33 /var/www/html/web/modules/contrib/webform_views/webform_views.module(220): Drupal\views\ViewExecutable->getBaseEntityType()
#34 /var/www/html/web/modules/contrib/webform_views/src/Routing/RouteSubscriber.php(42): webform_views_applicable_views()
#35 /var/www/html/web/core/lib/Drupal/Core/Routing/RouteSubscriberBase.php(37): Drupal\webform_views\Routing\RouteSubscriber->alterRoutes()
#36 /var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php(246): Drupal\Core\Routing\RouteSubscriberBase->onAlterRoutes()
#37 /var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php(206): Symfony\Component\EventDispatcher\EventDispatcher::Symfony\Component\EventDispatcher\{closure}()
#38 /var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php(56): Symfony\Component\EventDispatcher\EventDispatcher->callListeners()
#39 /var/www/html/web/core/lib/Drupal/Core/Routing/RouteBuilder.php(189): Symfony\Component\EventDispatcher\EventDispatcher->dispatch()
#40 /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Routing/RouteBuilder.php(83): Drupal\Core\Routing\RouteBuilder->rebuild()
#41 /var/www/html/web/core/includes/common.inc(454): Drupal\Core\ProxyClass\Routing\RouteBuilder->rebuild()
#42 /var/www/html/web/core/includes/utility.inc(41): drupal_flush_all_caches()
#43 /var/www/html/vendor/drush/drush/src/Commands/core/CacheRebuildCommands.php(60): drupal_rebuild()
#44 [internal function]: Drush\Commands\core\CacheRebuildCommands->rebuild()
#45 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array()
#46 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
#47 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
#48 /var/www/html/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(387): Consolidation\AnnotatedCommand\CommandProcessor->process()
#49 /var/www/html/vendor/symfony/console/Command/Command.php(279): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
#50 /var/www/html/vendor/symfony/console/Application.php(1094): Symfony\Component\Console\Command\Command->run()
#51 /var/www/html/vendor/symfony/console/Application.php(342): Symfony\Component\Console\Application->doRunCommand()
#52 /var/www/html/vendor/symfony/console/Application.php(193): Symfony\Component\Console\Application->doRun()
#53 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run()
#54 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
#55 /var/www/html/vendor/drush/drush/drush.php(140): Drush\Runtime\Runtime->run()
#56 /var/www/html/vendor/bin/drush.php(119): include('...')
#57 {main}
  thrown in /var/www/html/web/modules/contrib/ckeditor_media_embed/src/Embed.php on line 112

Comment #3

flyke commented 28 January 2025 at 10:21

Status	File	Size
new	ckeditor_media_embed-use-LibraryDiscoveryInterface-instead-of-LibraryDiscovery-3.patch	2.68 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	ckeditor_media_embed-use-LibraryDiscoveryInterface-instead-of-LibraryDiscovery-2.patch	1.59 KB

Fixed the new second issue in attached patch

Comment #4

rajab natshah

he/him

commented 3 February 2025 at 17:06

Issue tags:

+Drupal 11 compatibility

Comment #5

rajab natshah

he/him

commented 17 February 2025 at 15:21

Title:	CliCommandWrapper constructor requires LibraryDiscoveryInterface	» Fix CliCommandWrapper Constructor to Require LibraryDiscoveryInterface
Status:	Active	» Needs review

Comment #6

rajab natshah

he/him

commented 17 February 2025 at 15:26

Status:

Needs review

» Reviewed & tested by the community

Comment #7

rajab natshah

he/him

commented 17 February 2025 at 15:26

In need for a merge request

Comment #8

23 August 2025 at 17:19

grndlvl committed c459a1e0 on 2.x

Issue #3499886 by flyke, rajab natshah: Fix CliCommandWrapper...

Comment #9

grndlvl commented 23 August 2025 at 17:20

Status:

Reviewed & tested by the community

» Fixed

Comment #10

6 September 2025 at 17:24

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Fix CliCommandWrapper Constructor to Require LibraryDiscoveryInterface

Problem/Motivation

Steps to reproduce

Proposed resolution

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Referenced by

News items

Our community

Documentation

Drupal code base

Governance of community