Problem/Motivation

The recipe command runs duplicate batch jobs when recipes share dependencies.

Steps to reproduce

Apply the drupal_cms_starter recipe.

Proposed resolution

Only add same batch job once.

Remaining tasks

  1. Port solution from Drupal CMS installer to recipe command.
  2. Test.
  3. Review code.
  4. Commit.

User interface changes

None.

Introduced terminology

None.

API changes

None.

Data model changes

None.

Release notes snippet

The recipe command now runs only one batch job per dependency, even if the dependency appears multiple times.

Issue fork drupal-3499225

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

darren oh created an issue. See original summary.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Version: 11.1.x-dev » 11.x-dev

darren oh opened merge request !10886

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Active » Needs work

Fixed duplicate batch jobs. This doesn't remove all dependency errors, but it reduces them and improves performance.

thejimbirch’s picture

thejimbirch commented
Status: Needs work » Postponed (maintainer needs more info)

seems to ignore dependencies

Can you define what dependencies are ignored? The problem and steps to reproduce are quite vague.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Title: Fix recipe command ignoring dependencies » Fix recipe command running duplicate batch jobs
Issue summary: View changes

This report was based on errors I saw on the command line that I did not see in the Drupal CMS installer. It turned out to be because the installer disables recipe validation. So this issue is just about removing duplicate batch jobs.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Issue summary: View changes
thejimbirch’s picture

thejimbirch commented
Status: Postponed (maintainer needs more info) » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Believe we should have test coverage for such a problem.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Issue tags: +Drupal Forge, +Vienna2025
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Issue tags: -Vienna2025

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.