Problem/Motivation

Composer package nesbot/carbon has a security update.

Composer package ohdearapp/ohdear-php-sdk, requires nesbot/carbon.

ohdearapp/ohdear-php-sdk:^3.10.1 has dropped the depencency on nesbot/carbon.

Proposed resolution

Update our requirements so that it is impossible to install an insecure version.

This is just a precaution, mostly to prevent confusion / warning messages; I haven't looked into the details of the security issue but it's unlikely to affect us because nesbot/carbon is hardly being used.
This change will make no difference for people who have installed / update composer packages regularly, without the --prefer-lowest flag.

How to update: instead of requiring a minimum nesbot/carbon, just update to minimum ^3.10.1 which doesn't need it.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

roderik created an issue. See original summary.

roderik’s picture

Issue summary: View changes

roderik’s picture

Status: Active » Needs review

Used gitlab code editor for the first time.

roderik’s picture

Title: Update ohdear-php-sdk to secure version » Require ohdear-php-sdk version with secure dependencies
useernamee’s picture

Code looks good & tests are passing.
RTBC

Will merge and create a release.

useernamee’s picture

Status: Needs review » Reviewed & tested by the community

  • useernamee committed 34ec4a7e on 2.x authored by roderik
    Issue #3498786 by roderik, useernamee: Require ohdear-php-sdk version...
useernamee’s picture

Status: Reviewed & tested by the community » Fixed

merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.