Problem/Motivation

Tests are failing on 11.2

Issue fork diff-3498660

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !132

acbramley’s picture

acbramley commented
Status: Active » Needs work

For some reason after reverting via Set current revision the latest revision has a NULL value for revision_translation_affected which means it gets filtered out of the list. Need to figure out why that's happening.

idebr’s picture

idebr commented

These test failures now affect the regular 'phpunit' pipeline step

idebr’s picture

idebr commented
Related issues: +#3532698: phpstan dev constraints make it difficult for modules to support 11.2 and below
idebr’s picture

idebr commented
Title: Fix tests (next minor) » Fix tests

\Drupal\node\Form\NodeRevisionRevertForm does not call \Drupal\Core\Entity\ContentEntityStorageBase::createRevision that sets the revision_translation_affected.

See \Drupal\Core\Entity\Form\RevisionRevertForm::prepareRevision for reference

idebr’s picture

idebr commented

I filed an issue for Drupal Core: #3535230: Reverted revision is not listed on the version history when using Set as current revision

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 changed the visibility of the branch 2.x to hidden.

acbramley’s picture

acbramley commented
Status: Needs work » Fixed

Just going with commenting out those assertions for now, this is blocking other work on the module.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

acbramley’s picture

acbramley commented
Version: 2.x-dev » 8.x-1.x-dev
Status: Fixed » Needs work

let's get 8.x-1.x fixed too

acbramley opened merge request !148

acbramley’s picture

acbramley commented
Status: Needs work » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.